Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM CPU] Enable deconvolution SLT tests (New) #21263

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

allnes
Copy link
Contributor

@allnes allnes commented Nov 23, 2023

@allnes allnes added category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64 labels Nov 23, 2023
@allnes allnes added this to the 2023.3 milestone Nov 23, 2023
@allnes allnes requested review from a team as code owners November 23, 2023 20:50
@allnes allnes requested review from a team as code owners December 14, 2023 13:45
@allnes allnes requested review from tsavina and removed request for a team December 14, 2023 13:45
@allnes allnes requested a review from vurusovs January 12, 2024 16:50
@github-actions github-actions bot added the category: build OpenVINO cmake script / infra label Jan 30, 2024
@allnes allnes requested a review from alvoron February 1, 2024 15:16
@allnes allnes force-pushed the an/new_deconv_slt branch 5 times, most recently from 34b4c42 to 03d87ac Compare February 13, 2024 20:40
@allnes allnes modified the milestones: 2024.0, 2024.1 Feb 16, 2024
@allnes allnes requested a review from dmitry-gorokhov March 11, 2024 16:17
@github-actions github-actions bot removed the category: build OpenVINO cmake script / infra label Mar 22, 2024
@allnes allnes force-pushed the an/new_deconv_slt branch from beaaed5 to bc49ae4 Compare March 25, 2024 17:29
std::swap(shape[1], shape[2]);
std::swap(shape[2], shape[3]);

inline void changeLayoutToNH_C(const std::vector<arm_compute::TensorShape*> &_listDims) {
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My major concern is that we have quite untrivial logic to convert CPU internal memory representation to ACL one. We need to revert shape and adjust it in accordance with layout. The problem is that this is done with separate functions which need to be called explicitly. Easy to make a mistake.
Hopefull we can refactor this story during ACL Matmul implementation within new Executors arch.
@allnes @EgorDuplensky

@allnes allnes force-pushed the an/new_deconv_slt branch from cee22d3 to 4bcf8a8 Compare March 28, 2024 15:34
@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Mar 29, 2024
Merged via the queue into openvinotoolkit:master with commit 28d7184 Mar 29, 2024
103 checks passed
bbielawx pushed a commit to bbielawx/openvino that referenced this pull request Apr 12, 2024
CVS-118716
CVS-114087
CVS-127974
CVS-131706
CVS-132490
alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
CVS-118716
CVS-114087
CVS-127974
CVS-131706
CVS-132490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants