Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM CPU] Fix debug fails in acl tbb scheduler #20842

Merged
merged 6 commits into from
Nov 29, 2023

Conversation

allnes
Copy link
Contributor

@allnes allnes commented Nov 2, 2023

There are two fixes in this PR.
Fix 1:
For release and debug, scheduler destruct occurs at different points in time. The fix helps to replace the scheduler if it is deleted before the ACL internal check.
Fix 2:
Fixing window calculation for parallelism, in some tests results in degraded accuracy. The fix helps to ignore number of windows equal to 1.

@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Nov 2, 2023
@allnes allnes added the platform: arm OpenVINO on ARM / ARM64 label Nov 2, 2023
@allnes allnes marked this pull request as ready for review November 2, 2023 13:18
@allnes allnes requested review from a team as code owners November 2, 2023 13:18
@allnes allnes marked this pull request as draft November 2, 2023 13:19
@allnes allnes marked this pull request as ready for review November 2, 2023 14:08
@allnes allnes assigned allnes, alvoron and dmitry-gorokhov and unassigned allnes and alvoron Nov 2, 2023
@dmitry-gorokhov dmitry-gorokhov added this to the 2023.3 milestone Nov 9, 2023
@dmitry-gorokhov
Copy link
Contributor

@allnes Please explain the root-cause of the issue (like why it failed only in debug mode) and how your changes helps to fix it in the PR dsecription

@allnes
Copy link
Contributor Author

allnes commented Nov 23, 2023

@allnes Please explain the root-cause of the issue (like why it failed only in debug mode) and how your changes helps to fix it in the PR dsecription

@dmitry-gorokhov corrected

@dmitry-gorokhov dmitry-gorokhov merged commit 1b43b3c into openvinotoolkit:master Nov 29, 2023
62 checks passed
praasz pushed a commit to praasz/openvino that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants