[ARM CPU] Avg Pooling, ROI Pooling fix for fp16 precision #20658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kit#20294) * Enable device properties setting via AUTO plugin. * Update. * Update. * Update. * Update. * Update. * Update. * Update docs/OV_Runtime_UG/auto_device_selection.md Co-authored-by: yanlan song <bell.song@intel.com> * Add for stateful model * Fix the link --------- Co-authored-by: yanlan song <bell.song@intel.com> Co-authored-by: Chen Peter <peter.chen@intel.com>
* Update. * Update. * Update. * add test case. * Update. * Update test cases. * Update. * Update. * Updated. * Updated. * Updated. --------- Co-authored-by: Chen Peter <peter.chen@intel.com>
* [GPU] Fixed data generation for f16 fusion tests * [GPU] Temporary tolerance increase for failed tests on iGPU * [GPU] Temporary skip or tolerance increase for failed tests on dGPU
* [TF FE][TF Hub] Support Xlog1py operation * Update test_tf_Xlog1py.py
…envinotoolkit#20449) * Update cpp_benchmark_tool.md * Update cpp_benchmark_tool.md * Update cpp_benchmark_tool.md
…into an/general_fix_fp16
…into an/general_fix_fp16
…into an/general_fix_fp16 # Conflicts: # src/plugins/intel_cpu/tests/functional/shared_tests_instances/skip_tests_config.cpp
…into an/general_fix_fp16
…into an/general_fix_fp16
…into an/general_fix_fp16
EgorDuplensky
approved these changes
Oct 26, 2023
| @@ -453,6 +453,10 @@ void ROIPooling::initSupportedPrimitiveDescriptors() { | |||
| impl_type = impl_desc_type::ref; | |||
| } | |||
|
|
|||
| if (impl_type != impl_desc_type::ref && refParams.src_prc == Precision::FP16) { | |||
There was a problem hiding this comment.
let's have src_prc assignment in one place of the function
There was a problem hiding this comment.
@EgorDuplensky corrected
dmitry-gorokhov
approved these changes
Oct 27, 2023
alvoron
pushed a commit
to alvoron/openvino
that referenced
this pull request
Nov 6, 2023
allnes
added a commit
to allnes/openvino
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: