[ARM CPU] New version of scheduler enabling #20488

allnes · 2023-10-16T11:10:04Z

Tickets:

EgorDuplensky · 2023-10-23T14:36:53Z

src/plugins/intel_cpu/src/plugin.cpp

 Engine::Engine() :
    deviceFullName(getDeviceFullName()),
    specialSetup(new CPUSpecialSetup) {
    _pluginName = "CPU";
    extensionManager->AddExtension(std::make_shared<Extension>());
 #if defined(OV_CPU_WITH_ACL)
-    scheduler_guard = SchedulerGuard::instance();
+    std::lock_guard<std::mutex> _lock {get_mtx_acl()};


I propose to wrap it into a function like setAclScheduler.
Also a question, why we are doing it in scope of an engine creation in case of ACL but doing it somewhere else in case of other arch?

Personally I don't like the fact we initialize it i scope of the engine, while for the x86 we are doing it in scope of creation of exec network before graph initialization.
@dmitry-gorokhov Up to you to approve (considering all the circumstances)

@EgorDuplensky @dmitry-gorokhov corrected it

EgorDuplensky · 2023-10-23T16:17:56Z

src/plugins/intel_cpu/src/plugin.cpp

 Engine::Engine() :
    deviceFullName(getDeviceFullName()),
    specialSetup(new CPUSpecialSetup) {
    _pluginName = "CPU";
    extensionManager->AddExtension(std::make_shared<Extension>());
 #if defined(OV_CPU_WITH_ACL)
-    scheduler_guard = SchedulerGuard::instance();
+    std::lock_guard<std::mutex> _lock {get_mtx_acl()};


Personally I don't like the fact we initialize it i scope of the engine, while for the x86 we are doing it in scope of creation of exec network before graph initialization.
@dmitry-gorokhov Up to you to approve (considering all the circumstances)

EgorDuplensky · 2023-10-24T11:34:42Z

src/plugins/intel_cpu/src/nodes/executors/acl/acl_utils.hpp

+* @param config ComputeLibrary configuration function
+*/
+inline void lockACLConfiguration(std::function<void(void)> config) {
+    // We get a problem (seg. faults, data race etc) for eltwise operations when we use several configure(...) functions in parallel.


Please put it into the doxygen part above instead.
"ACL 28.08 does not officially support thread-safe configure() calls.
For example, calling configure for Eltwise operations from multiple streams leads to a data race and seg fault."

@EgorDuplensky corrected it

EgorDuplensky · 2023-10-24T11:35:54Z

src/plugins/intel_cpu/src/nodes/executors/acl/acl_utils.hpp

+    // We created issue about this problem here: https://github.com/ARM-software/ComputeLibrary/issues/1073
+    // TODO: change it when we will get an answer to our question in issue


This better to be mentioned in the ticket, not in the source code

@EgorDuplensky corrected it

EgorDuplensky · 2023-10-24T11:46:16Z

src/plugins/intel_cpu/src/nodes/executors/acl/acl_utils.hpp

+* @brief Return static mutex for lock ComputeLibrary configuration
+* @return static std::mutex
+*/
+static arm_compute::Mutex & getMutexConfig() {


Abbreviation Config in this case is misleading.
Let's have just getConfigurationMutex

@EgorDuplensky corrected it

EgorDuplensky · 2023-10-24T11:50:01Z

src/plugins/intel_cpu/src/nodes/executors/acl/acl_utils.hpp

+* @brief run thread-safe configure for ComputeLibrary configuration function
+* @param config ComputeLibrary configuration function
+*/
+inline void lockACLConfiguration(std::function<void(void)> config) {


maybe configureThreadSafe()

@EgorDuplensky corrected it

EgorDuplensky · 2023-11-07T15:43:54Z

@allnes Could you please rebase on latest master fetch api 2.0 changes

github-actions · 2023-11-29T00:18:15Z

This PR will be closed in a week because of 2 weeks of no activity.

github-actions · 2023-12-14T00:17:59Z

This PR will be closed in a week because of 2 weeks of no activity.

github-actions · 2024-01-04T00:18:22Z

This PR will be closed in a week because of 2 weeks of no activity.

EgorDuplensky

@allnes Could you please include the validation runs into some ticket

github-actions · 2024-01-21T00:20:18Z

This PR will be closed in a week because of 2 weeks of no activity.

github-actions · 2024-01-29T00:17:43Z

This PR was closed because it has been stalled for 2 week with no activity.

src/plugins/intel_cpu/src/compiled_model.cpp

src/plugins/intel_cpu/src/nodes/executors/acl/acl_utils.hpp

src/plugins/intel_cpu/src/compiled_model.cpp

src/plugins/intel_cpu/src/nodes/executors/acl/acl_utils.hpp

maxnick

LGTM

maxnick · 2024-03-21T13:45:16Z

PR needs internal performance validation

maxnick · 2024-03-27T13:41:16Z

Internal performance validation passed successfully

### Tickets: - CVS-132497 - CVS-129036 - CVS-134932

allnes added category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64 labels Oct 16, 2023

allnes added this to the 2023.2 milestone Oct 16, 2023

allnes requested review from a team as code owners October 16, 2023 11:10

EgorDuplensky reviewed Oct 23, 2023

View reviewed changes

allnes requested a review from EgorDuplensky October 24, 2023 10:15

EgorDuplensky reviewed Oct 24, 2023

View reviewed changes

allnes requested review from EgorDuplensky and dmitry-gorokhov October 24, 2023 14:15

dmitry-gorokhov assigned dmitry-gorokhov and EgorDuplensky Nov 2, 2023

dmitry-gorokhov modified the milestones: 2023.2, 2023.3 Nov 2, 2023

github-actions bot added the Stale label Nov 29, 2023

allnes removed the Stale label Nov 29, 2023

github-actions bot added the Stale label Dec 14, 2023

allnes removed the Stale label Dec 14, 2023

dmitry-gorokhov modified the milestones: 2023.3, 2024.0 Dec 20, 2023

github-actions bot added the Stale label Jan 4, 2024

EgorDuplensky reviewed Jan 5, 2024

View reviewed changes

github-actions bot removed the Stale label Jan 6, 2024

github-actions bot added the Stale label Jan 21, 2024

allnes force-pushed the an/acl_scheduler_fix branch 2 times, most recently from 5aedae7 to 9a8e9c3 Compare February 14, 2024 15:43

allnes modified the milestones: 2024.0, 2024.1 Feb 16, 2024

allnes force-pushed the an/acl_scheduler_fix branch 2 times, most recently from c976610 to 93bc5cb Compare February 19, 2024 16:05

allnes assigned maxnick Feb 29, 2024

maxnick reviewed Mar 4, 2024

View reviewed changes

maxnick requested a review from EgorDuplensky March 4, 2024 19:32

maxnick reviewed Mar 4, 2024

View reviewed changes

src/plugins/intel_cpu/src/compiled_model.cpp Outdated Show resolved Hide resolved

maxnick reviewed Mar 12, 2024

View reviewed changes

src/plugins/intel_cpu/src/compiled_model.cpp Outdated Show resolved Hide resolved

src/plugins/intel_cpu/src/compiled_model.cpp Outdated Show resolved Hide resolved

maxnick added the pr: needs tests PR needs tests updating label Mar 12, 2024

maxnick reviewed Mar 18, 2024

View reviewed changes

src/plugins/intel_cpu/src/compiled_model.cpp Outdated Show resolved Hide resolved

maxnick reviewed Mar 18, 2024

View reviewed changes

src/plugins/intel_cpu/src/nodes/executors/acl/acl_utils.hpp Outdated Show resolved Hide resolved

allnes removed this from the 2024.1 milestone Mar 18, 2024

maxnick approved these changes Mar 21, 2024

View reviewed changes

maxnick added do_not_merge and removed pr: needs tests PR needs tests updating labels Mar 21, 2024

allnes force-pushed the an/acl_scheduler_fix branch 2 times, most recently from 02406f4 to b03eb48 Compare March 26, 2024 14:21

scheduler init

dbad1b9

allnes force-pushed the an/acl_scheduler_fix branch from b03eb48 to dbad1b9 Compare March 26, 2024 14:25

maxnick removed the do_not_merge label Mar 27, 2024

maxnick added this pull request to the merge queue Mar 27, 2024

Merged via the queue into openvinotoolkit:master with commit dc2416c Mar 27, 2024
103 checks passed

bbielawx pushed a commit to bbielawx/openvino that referenced this pull request Apr 12, 2024

[ARM CPU] New version of scheduler enabling (openvinotoolkit#20488)

0900dc7

### Tickets: - CVS-132497 - CVS-129036 - CVS-134932

alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024

[ARM CPU] New version of scheduler enabling (openvinotoolkit#20488)

78834a9

### Tickets: - CVS-132497 - CVS-129036 - CVS-134932

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ARM CPU] New version of scheduler enabling #20488

[ARM CPU] New version of scheduler enabling #20488

allnes commented Oct 16, 2023 •

edited

Loading

EgorDuplensky Oct 23, 2023

EgorDuplensky Oct 23, 2023

allnes Oct 24, 2023

EgorDuplensky Oct 23, 2023

EgorDuplensky Oct 24, 2023

allnes Oct 24, 2023

EgorDuplensky Oct 24, 2023

allnes Oct 24, 2023

EgorDuplensky Oct 24, 2023

allnes Oct 24, 2023

EgorDuplensky Oct 24, 2023

allnes Oct 24, 2023

EgorDuplensky commented Nov 7, 2023

github-actions bot commented Nov 29, 2023

github-actions bot commented Dec 14, 2023

github-actions bot commented Jan 4, 2024

EgorDuplensky left a comment

github-actions bot commented Jan 21, 2024

github-actions bot commented Jan 29, 2024

maxnick left a comment

maxnick commented Mar 21, 2024

maxnick commented Mar 27, 2024

		// We created issue about this problem here: https://github.com/ARM-software/ComputeLibrary/issues/1073
		// TODO: change it when we will get an answer to our question in issue

[ARM CPU] New version of scheduler enabling #20488

[ARM CPU] New version of scheduler enabling #20488

Conversation

allnes commented Oct 16, 2023 • edited Loading

Tickets:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EgorDuplensky commented Nov 7, 2023

github-actions bot commented Nov 29, 2023

github-actions bot commented Dec 14, 2023

github-actions bot commented Jan 4, 2024

EgorDuplensky left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 21, 2024

github-actions bot commented Jan 29, 2024

maxnick left a comment

Choose a reason for hiding this comment

maxnick commented Mar 21, 2024

maxnick commented Mar 27, 2024

allnes commented Oct 16, 2023 •

edited

Loading