【Hackathon 5th No.94】add paddle partial_op #20103
Conversation
Asthestarsfalll
changed the title
| namespace paddle { | ||
| namespace op { | ||
|
|
||
| template <typename T> |
There was a problem hiding this comment.
Can we use this template you defined to connect these 2 ops ? which may help to enable more partial like ops.
There was a problem hiding this comment.
I have tried some methods but failed.
Add op requires two Node as inputs, but Concat op requires a NodeVector and a integer to specify operate on which axis
|
@yuxu42 Could you help to have a review on this PR, thanks |
|
@meiyang-intel could you please help review? Thanks! |
yuxu42
added
ExternalPR
|
This PR will be closed in a week because of 2 weeks of no activity. |
|
@Asthestarsfalll could you please fix the CI issues? Thanks! |
It was interupted when building ade. I think it's unrelated to this pr. There is no any extra information: |
|
Hi @Asthestarsfalll , can the test pass both in paddlepaddle v2.4.2 and v2.5.2 ? |
The interface for partial_sum and partial_concat has been moved from paddle.fluid.contrib.layers to paddle.incubate.layers since v2.5. So I add an if statement to handle this. |
|
@meiyang-intel Hi, Could you please take a look? |
meiyang-intel
force-pushed
the
partial
branch
from
2fb5f27
to
bb3785c
Compare
meiyang-intel
force-pushed
the
partial
branch
from
bb3785c
to
f31536a
Compare
|
This PR will be closed in a week because of 2 weeks of no activity. |
Details:
add paddle partial_concat and partial_sum
Reference
Code: https://github.com/PaddlePaddle/Paddle/blob/release/2.5/python/paddle/incubate/layers/nn.py#L512-L637
https://github.com/PaddlePaddle/Paddle2ONNX/blob/develop/paddle2onnx/mapper/tensor/partial_ops.cc
Support data type: float32, float64 (openvino do not support float64), int32, int64
Test
waiting for:
PaddlePaddle/Paddle#57262