Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 5th No.96】add paddle unstack op #20080

Merged
merged 7 commits into from
Nov 22, 2023

Conversation

@Patrick-Star125 Patrick-Star125 requested a review from a team as a code owner September 27, 2023 09:47
@github-actions github-actions bot added the category: PDPD FE OpenVINO PaddlePaddle FrontEnd label Sep 27, 2023
@Patrick-Star125 Patrick-Star125 changed the title 【PaddlePaddle Hackathon 5】add paddle unstack op 【PaddlePaddle Hackathon 5 No.96】add paddle unstack op Sep 28, 2023
@Patrick-Star125 Patrick-Star125 changed the title 【PaddlePaddle Hackathon 5 No.96】add paddle unstack op 【Hackathon 5th No.96】add paddle unstack op Sep 28, 2023
auto data = node.get_input("X");
auto dim = node.get_attribute<int32_t>("axis");
if (dim < 0) {
dim = dim + data.get_partial_shape().rank().get_length();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@openvino-dev-samples openvino-dev-samples Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you validated it again? Could you help to update your uni-test screenshot if not ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, missed the notification email, we should keep these code because index access of shape is bounded within [0, abs(dim)-1]

@openvino-dev-samples
Copy link
Contributor

@yuxu42 Could you help to have a review on this PR, thanks

@yuxu42
Copy link
Contributor

yuxu42 commented Nov 6, 2023

@liubo-intel Could you please help review? Thanks!

@Patrick-Star125
Copy link
Contributor Author

Done

@yuxu42 yuxu42 added ExternalPR External contributor PaddlePaddle Hackathon a Intel and Baidu joint Hackathon event labels Nov 10, 2023
@liubo-intel
Copy link
Contributor

Hi, @Patrick-Star125 : please fix the clang-format issue by following suggestion of the CI log.
clang_format_issue

@yuxu42
Copy link
Contributor

yuxu42 commented Nov 16, 2023

@ceciliapeng2011 can we merge the PR? Thanks!

@ceciliapeng2011 ceciliapeng2011 merged commit d85e6c3 into openvinotoolkit:master Nov 22, 2023
36 checks passed
allnes pushed a commit to allnes/openvino that referenced this pull request Nov 23, 2023
* add paddle mapping

* develop test sampes

* remove redundant code

* revoke code change

* add type mapping

* add test sample

* format code

---------

Co-authored-by: Your Name <you@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PDPD FE OpenVINO PaddlePaddle FrontEnd ExternalPR External contributor PaddlePaddle Hackathon a Intel and Baidu joint Hackathon event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants