Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT FE]: extend logical operations support #19981

Merged
merged 3 commits into from
Sep 22, 2023
Merged

[PT FE]: extend logical operations support #19981

merged 3 commits into from
Sep 22, 2023

Conversation

eaidova
Copy link
Contributor

@eaidova eaidova commented Sep 21, 2023

Details:

  • added support aten::logical_and, aten::logical_or, aten::logical_not, aten::logical_xor

Tickets:

  • ticket-id

@eaidova eaidova requested a review from a team as a code owner September 21, 2023 07:14
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Sep 21, 2023
@eaidova eaidova requested a review from mvafin September 21, 2023 07:15
mvafin
mvafin approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does aten::logical_* support non-boolean inputs? Do they work as bitwise ops in that case or boolean ops?

@eaidova
Copy link
Contributor Author

eaidova commented Sep 21, 2023

Does aten::logical_* support non-boolean inputs? Do they work as bitwise ops in that case or boolean ops?

Does aten::logical_* support non-boolean inputs? Do they work as bitwise ops in that case or boolean ops?

bitwise accepts only bool and int8 and for bool works as boolean and for int as bitwise
logical accept different types and convert them to bool

@eaidova eaidova merged commit 8d59fcd into openvinotoolkit:master Sep 22, 2023
57 checks passed
@eaidova eaidova deleted the ea/logical_ops branch September 22, 2023 06:11
alvoron pushed a commit to alvoron/openvino that referenced this pull request Nov 6, 2023
@eaidova @alvoron
[PT FE]: extend logical operations support (openvinotoolkit#19981)
dd99d0f 
* [PT FE]: extend logical operations support

* tests

* more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvafin mvafin mvafin approved these changes

@suryasidd suryasidd Awaiting requested review from suryasidd suryasidd is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

Assignees
No one assigned
Labels
category: PyTorch FE OpenVINO PyTorch Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eaidova @mvafin