-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align openvino.compile_model and openvino.Core.compile_model functions #19778
Align openvino.compile_model and openvino.Core.compile_model functions #19778
Conversation
build_jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! LGTM, I left one minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One major thing to change. Tests are optional and I will really appreciate considering rewriting of them.
Overall good PR! 👍
Hey guys, I've tried to combine implementation of I've also combined For Please let me know if something needs fixed (probably does) |
Hello @siddhant-0707, it seems there are some assertion errors in the Azure checks, could you please take a look? Additionally, some Jenkins check require manual running by a maintainer, but you can also run them yourself by adding a GitHub comment with |
build_jenkins |
added `test_compile_model` and `test_compile_model_without_device` which test core.compile_model
… into `test_compile_model`
Hey @akuporos I've combined |
Co-Authored-By: Anastasia Kuporosova <anastasia.kuporosova@intel.com>
build_jenkins |
@siddhant-0707 please, fix pylint checks |
build_jenkins |
build_jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks for this contribution 🥇
openvinotoolkit#19778) Co-Authored-By: Anastasia Kuporosova <anastasia.kuporosova@intel.com>
Details:
openvino.compile_model
andopenvino.Core.compile_model
functionsopenvino.compile_model
Tickets:
openvino.compile_model
andopenvino.Core.compile_model
functions #19616