Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled debug build for Python wheels #19197

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Enabled debug build for Python wheels #19197

merged 1 commit into from
Aug 17, 2023

Conversation

ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov added this to the 2023.2 milestone Aug 15, 2023
@ilya-lavrenov ilya-lavrenov requested review from a team as code owners August 15, 2023 08:49
@ilya-lavrenov ilya-lavrenov requested review from AlexKoff88 and jiwaszki and removed request for a team August 15, 2023 08:49
@github-actions github-actions bot added category: build OpenVINO cmake script / infra category: Python API OpenVINO Python bindings category: dependency_changes Pull requests that update a dependency file category: packaging OpenVINO packaging / distribution labels Aug 15, 2023
@ilya-lavrenov ilya-lavrenov assigned slyalin and sspintel and unassigned slyalin Aug 15, 2023
jiwaszki
jiwaszki approved these changes Aug 16, 2023
View reviewed changes
Copy link

@jiwaszki jiwaszki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it be included from 2023.1 or 2023.2?

@ilya-lavrenov
Copy link
Contributor Author

Will it be included from 2023.1 or 2023.2?

2023.2
I don't want to accidently break 2023.1. The fix is not critical

@ilya-lavrenov ilya-lavrenov merged commit e49b208 into openvinotoolkit:master Aug 17, 2023
25 checks passed
@ilya-lavrenov ilya-lavrenov deleted the debug-wheels branch August 17, 2023 12:45
ilya-lavrenov added a commit to ilya-lavrenov/openvino that referenced this pull request Sep 13, 2023
@ilya-lavrenov
Revert "Enabled debug build for Python wheels (openvinotoolkit#19197)"
c17f5d4 
This reverts commit e49b208.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiwaszki jiwaszki jiwaszki approved these changes

@AlexKoff88 AlexKoff88 Awaiting requested review from AlexKoff88 AlexKoff88 is a code owner automatically assigned from openvinotoolkit/openvino-configuration-mgmt

Assignees

@slyalin slyalin

@sspintel sspintel

Labels
category: build OpenVINO cmake script / infra category: dependency_changes Pull requests that update a dependency file category: packaging OpenVINO packaging / distribution category: Python API OpenVINO Python bindings
Projects
None yet
Milestone
2023.2
Development

Successfully merging this pull request may close these issues.

OpenVINO Wheel does not install Debug libraries when CMAKE_BUILD_TYPE is Debug
4 participants
@ilya-lavrenov @jiwaszki @slyalin @sspintel