Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM CPU] Remove configure from exec func in eltwise, reduce and pooling #19071

Merged
merged 9 commits into from
Aug 30, 2023

Conversation

allnes
Copy link
Contributor

@allnes allnes commented Aug 8, 2023

On our executor's conception:
we call once arm_compute::configure in init() function and call few times arm_compute::run in exec() function

In our cases for eltwise, reduce and pooling we created lambda functions for arm_compute::configure and arm_compute::run in init(), but call every time in exec

this problem could be affect performance and create some problems with threading and streams

This PR fix it and correct realisation with our concept

@allnes allnes added category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64 labels Aug 8, 2023
@allnes allnes requested a review from alvoron August 8, 2023 16:35
@allnes allnes requested review from a team as code owners August 8, 2023 16:35
@allnes allnes changed the title [ARM CPU] Move configure from exec func in eltwise op [ARM CPU] Remove configure from exec func in eltwise, reduce and pooling Aug 8, 2023
@allnes allnes added this to the 2023.1 milestone Aug 8, 2023
@dmitry-gorokhov
Copy link
Contributor

@allnes We need detailed explanation why this PR neeede in the desctiption. Link to the JIRA (if exists) also required.

@allnes
Copy link
Contributor Author

allnes commented Aug 9, 2023

@allnes We need detailed explanation why this PR neeede in the desctiption. Link to the JIRA (if exists) also required.

@dmitry-gorokhov wrote, please check

@allnes allnes modified the milestones: 2023.1, 2023.2 Aug 9, 2023
@dmitry-gorokhov dmitry-gorokhov merged commit f2167a9 into openvinotoolkit:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants