-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARM CPU] Remove configure from exec func in eltwise, reduce and pooling #19071
Merged
dmitry-gorokhov
merged 9 commits into
openvinotoolkit:master
from
allnes:an/eltwise_ifunc
Aug 30, 2023
Merged
[ARM CPU] Remove configure from exec func in eltwise, reduce and pooling #19071
dmitry-gorokhov
merged 9 commits into
openvinotoolkit:master
from
allnes:an/eltwise_ifunc
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into an/eltwise_ifunc
allnes
added
category: CPU
OpenVINO CPU plugin
platform: arm
OpenVINO on ARM / ARM64
labels
Aug 8, 2023
allnes
changed the title
[ARM CPU] Move configure from exec func in eltwise op
[ARM CPU] Remove configure from exec func in eltwise, reduce and pooling
Aug 8, 2023
alvoron
approved these changes
Aug 8, 2023
@allnes We need detailed explanation why this PR neeede in the desctiption. Link to the JIRA (if exists) also required. |
@dmitry-gorokhov wrote, please check |
dmitry-gorokhov
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On our executor's conception:
we call once arm_compute::configure in init() function and call few times arm_compute::run in exec() function
In our cases for eltwise, reduce and pooling we created lambda functions for arm_compute::configure and arm_compute::run in init(), but call every time in exec
this problem could be affect performance and create some problems with threading and streams
This PR fix it and correct realisation with our concept