Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARM CPU] ACL TBB scheduler #17445

Merged
merged 25 commits into from
Jul 19, 2023
Merged

[ARM CPU] ACL TBB scheduler #17445

merged 25 commits into from
Jul 19, 2023

Conversation

allnes
Copy link
Contributor

@allnes allnes commented May 9, 2023

No description provided.

@allnes allnes added category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64 labels May 9, 2023
@allnes allnes added this to the 2023.1 milestone May 9, 2023
@alvoron alvoron mentioned this pull request May 11, 2023
Closed
allnes added 8 commits May 16, 2023 18:09
@allnes
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
04eb077 
…into an/tbb_scheduler_exp
@allnes
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
a25f2cc 
…into an/tbb_scheduler_exp
@allnes
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
b527a92 
…into an/tbb_scheduler_exp
@allnes
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
4a585b5 
…into an/tbb_scheduler_exp
@allnes
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
e9316b5 
…into an/tbb_scheduler_exp
@allnes
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
69efd08 
…into an/tbb_scheduler_exp
@allnes
Merge branch 'master' into an/tbb_scheduler_exp
607f56c
@allnes
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
871dd8d 
…into an/tbb_scheduler_exp
@wangleis wangleis mentioned this pull request May 29, 2023
Merged
@github-actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jun 26, 2023
@github-actions github-actions bot removed the Stale label Jun 30, 2023
@allnes allnes marked this pull request as ready for review July 3, 2023 15:11
@allnes allnes requested review from a team as code owners July 3, 2023 15:11
@allnes allnes changed the title [ARM CPU] ACL TBB scheduler experiment [ARM CPU] ACL TBB scheduler Jul 13, 2023
@alvoron
Copy link
Contributor

alvoron commented Jul 13, 2023

Should we keep scheduler in executors folder?

dmitry-gorokhov
dmitry-gorokhov reviewed Jul 18, 2023
View reviewed changes
src/plugins/intel_cpu/src/nodes/executors/acl/acl_ie_scheduler.cpp

unsigned int ACLScheduler::num_threads() const { return parallel_get_num_threads(); }

void ACLScheduler::set_num_threads(unsigned int num_threads) {}
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov Jul 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method has to be implemented in proper way. You can have num_threads internal field initialized with parallel_get_num_threads(); as default value.
Then run_workloads can be implemented using InferenceEngine::parallel_nt which takes number of threads as parameter.
Anyway this need to aligned with streams support activity to provide proper behavior inside TBB arena. This might be not trivial given ACL has only global scheduler instance.
Lets follow-up later

@dmitry-gorokhov
Copy link
Contributor

Should we keep scheduler in executors folder?

I think current place is good enough until we will not have dedicated place with per-target global configuration logic

@dmitry-gorokhov
Copy link
Contributor

@allnes Please rebase on latest master to get fresh CI.

@dmitry-gorokhov dmitry-gorokhov merged commit 510f578 into openvinotoolkit:master Jul 19, 2023
allnes added a commit to allnes/openvino that referenced this pull request Jul 24, 2023
@allnes
Revert "[ARM CPU] ACL TBB scheduler (openvinotoolkit#17445)"
ceb74e0 
This reverts commit 510f578.
alvoron pushed a commit to alvoron/openvino that referenced this pull request Jul 24, 2023
@allnes @alvoron
[ARM CPU] ACL TBB scheduler (openvinotoolkit#17445)
9796a2b
allnes added a commit to allnes/openvino that referenced this pull request Jul 27, 2023
@allnes
rRevert "[ARM CPU] ACL TBB scheduler (openvinotoolkit#17445)"
bd412b2 
This reverts commit 510f578.
dmitry-gorokhov pushed a commit that referenced this pull request Jul 27, 2023
@allnes
Revert "[ARM CPU] ACL TBB scheduler (#17445)" (#18821)
1857c7a 
This reverts commit 510f578.
allnes added a commit to allnes/openvino that referenced this pull request Jul 31, 2023
@allnes
Revert "Revert "[ARM CPU] ACL TBB scheduler (openvinotoolkit#17445)" (o…
b64a236 
…penvinotoolkit#18821)"

This reverts commit 1857c7a.
@allnes allnes mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xufang-lisa xufang-lisa xufang-lisa left review comments

@wangleis wangleis wangleis approved these changes

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

@maxnick maxnick Awaiting requested review from maxnick

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels
category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64
Projects
None yet
Milestone
2023.1
Development

Successfully merging this pull request may close these issues.
5 participants
@allnes @alvoron @dmitry-gorokhov @wangleis @xufang-lisa