[ARM CPU] Add ACL executor for Convert #17323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
allnes
commented
May 2, 2023
allnes
commented
- Separate executors
- Add ACL executor for convert
|
This PR will be closed in a week because of 2 weeks of no activity. |
…into an/init_acl_convert
| auto selectedPD = getSelectedPrimitiveDescriptor(); | ||
| std::vector<MemoryDescPtr> srcDescs = {parentMem.getDescPtr()}; | ||
| std::vector<MemoryDescPtr> dstDescs = {childMem.getDescPtr()}; | ||
| execPtr = selectedPD->getExecutorFactoryAs<ConvertExecutorFactory>()->makeExecutor(convertParams, |
There was a problem hiding this comment.
Could you please create a prepareParams method for the convert node to align with the rest of the nodes.
| const std::vector<MemoryDescPtr>& srcDescs, | ||
| const std::vector<MemoryDescPtr>& dstDescs) const override { | ||
| if (convertParams.srcPrc != convertParams.dstPrc) { | ||
| if (convertParams.srcPrc != InferenceEngine::Precision::I8 && |
There was a problem hiding this comment.
Please use one_of() utils method for such cases
Here and below
| @@ -217,7 +217,7 @@ void Transformations::PreLpt(const std::vector<ov::element::Type>& defaultPrecis | |||
| {ov::element::u16, ov::element::i32}, | |||
| {ov::element::u32, ov::element::i32}, | |||
| {ov::element::f64, ov::element::f32}, | |||
| {ov::element::f16, ov::element::f32}, | |||
| //{ov::element::f16, ov::element::f32}, | |||
| @@ -122,7 +122,7 @@ inline InferenceEngine::Precision normalizeToSupportedPrecision(InferenceEngine: | |||
| break; | |||
| } | |||
| case InferenceEngine::Precision::FP16: { | |||
| precision = InferenceEngine::Precision::FP32; | |||
| //precision = InferenceEngine::Precision::FP32; | |||
EgorDuplensky
approved these changes
Jul 5, 2023
maxnick
reviewed
Jul 7, 2023
src/plugins/intel_cpu/src/nodes/executors/common/ref_convert.hpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_cpu/src/nodes/executors/common/ref_convert.hpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_cpu/src/nodes/executors/common/ref_convert.hpp
Outdated
Show resolved
Hide resolved
maxnick
reviewed
Jul 10, 2023
src/plugins/intel_cpu/src/nodes/executors/common/ref_convert.hpp
Outdated
Show resolved
Hide resolved
maxnick
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.