Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM CPU] Add ACL executor for Transpose #17322

Merged
merged 32 commits into from
Jul 14, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
4a36322
separate executors + add acl executor fot transpose
allnes May 2, 2023
b7cbec1
Merge branch 'master' into an/init_acl_transpose
allnes May 2, 2023
8af5197
correct axisCast
allnes May 2, 2023
925b23d
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
allnes May 2, 2023
80decf8
Merge remote-tracking branch 'origin/an/init_acl_transpose' into an/i…
allnes May 2, 2023
d1ee0ea
update transpose executors list
allnes May 2, 2023
cdcfe92
Merge branch 'master' into an/init_acl_transpose
allnes May 4, 2023
c691ac5
Merge branch 'master' into an/init_acl_transpose
allnes May 23, 2023
e1facff
Merge branch 'master' into an/init_acl_transpose
allnes Jun 14, 2023
c56e403
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
allnes Jun 14, 2023
bc101fc
update new changes
allnes Jun 14, 2023
fe190f6
Merge remote-tracking branch 'origin/an/init_acl_transpose' into an/i…
allnes Jun 14, 2023
f63d5fa
enable tests
alvoron Jun 16, 2023
f384d01
fix fortting
alvoron Jun 19, 2023
5d37d33
fixed test shapes and transpose generalization
alvoron Jun 19, 2023
6b0d4d7
fixed different signedness error
alvoron Jun 20, 2023
0252dc2
size_t usage in loop counters
alvoron Jun 20, 2023
7e737b0
undo unwanted changes
alvoron Jun 20, 2023
1c3943b
fixed comments
alvoron Jun 21, 2023
d0d8046
added i8 and fp32 to blocked x86 tests
alvoron Jun 26, 2023
02bd01b
Merge branch 'master' into an/init_acl_transpose
alvoron Jun 27, 2023
cd97879
fixed comments
alvoron Jul 7, 2023
6f69ae3
fixed comments
alvoron Jul 10, 2023
62e25dc
extracted general reference executor from PermuteKernel
alvoron Jul 12, 2023
0705def
Merge branch 'master' into an/init_acl_transpose
alvoron Jul 12, 2023
c8129e4
fix mayiuse in JitTransposeExecutorBuilder::isSupported
alvoron Jul 12, 2023
da2a640
getDescWithType name refactoring
alvoron Jul 12, 2023
b80b245
refactoring
alvoron Jul 12, 2023
95f42c6
removed 2nd executor creation in transpose node
alvoron Jul 12, 2023
4ec932a
Moved RefOptimizedTranspose to the top
alvoron Jul 13, 2023
432bfce
fixed comments
alvoron Jul 13, 2023
d6a9fa0
Merge branch 'master' into an/init_acl_transpose
alvoron Jul 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed 2nd executor creation in transpose node
  • Loading branch information
alvoron committed Jul 12, 2023
commit 95f42c69ddebad41ef175ff157c805e774e5feb9
13 changes: 0 additions & 13 deletions src/plugins/intel_cpu/src/nodes/transpose.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,6 @@ bool Transpose::isExecutable() const {
}

bool Transpose::needPrepareParams() const {
if (isOptimized)
return false;
return inputShapesModified();
}

Expand Down Expand Up @@ -270,17 +268,6 @@ void Transpose::createPrimitive() {
getChildEdgeAt(0)->getMemory().getDesc().hasLayoutType(LayoutType::ncsp) &&
order == std::vector<size_t>{0, 3, 1, 2}) {
performAsReorder = true;
} else if (getParentEdgeAt(INPUT_DATA_IDX)->getMemory().getDesc().hasLayoutType(LayoutType::ncsp) &&
std::find(optimizedOrders.begin(), optimizedOrders.end(), order) != optimizedOrders.end()) {
isOptimized = true;
dnnl::primitive_attr attr;
auto selectedPD = getSelectedPrimitiveDescriptor();
execPtr = selectedPD->getExecutorFactoryAs<TransposeExecutorFactory>()->makeExecutor(transposeParams,
{srcMemPtr->getDescPtr()},
{dstMemPtr->getDescPtr()},
attr);
selectedPD->setImplementationType(execPtr->getImplType());
return;
}

if (!performAsReorder) {
Expand Down
7 changes: 0 additions & 7 deletions src/plugins/intel_cpu/src/nodes/transpose.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,6 @@ class Transpose : public Node {
dnnl::primitive prim;
InferenceEngine::SizeVector order;
InferenceEngine::Precision prec;
bool isOptimized = false;

const std::vector<std::vector<size_t>> optimizedOrders = {
std::vector<size_t>{0, 3, 1, 2},
std::vector<size_t>{0, 4, 1, 2, 3},
std::vector<size_t>{0, 5, 1, 2, 3, 4},
};

TransposeParams transposeParams;

Expand Down