[ARM CPU] Fix AVGPool tests #17272
Merged
[ARM CPU] Fix AVGPool tests #17272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| DimensionRoundingType round = (poolingAttrs.rounding == op::RoundingType::CEIL) ? | ||
| DimensionRoundingType::CEIL : DimensionRoundingType::FLOOR; | ||
|
|
||
| if (dataLayout == arm_compute::DataLayout::NCHW && poolingAttrs.rounding == op::RoundingType::CEIL) return false; |
There was a problem hiding this comment.
how does CEIL and NHWC work?
There was a problem hiding this comment.
The combination of parameters: NCHW + CEIL gives an accuracy problem in AvgPool. One workaround is to disable the ACL executor for these parameters. Then OneDNN will run this case in ACL backend as reorder -> NHWC -> reorder and combination NHWC + CEIL without accuracy drop.
There was a problem hiding this comment.
@ilya-lavrenov I corrected rounding, for other cases.
EgorDuplensky
approved these changes
Apr 28, 2023
ilya-lavrenov
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combination of parameters: NCHW + CEIL gives an accuracy problem in AvgPool. One workaround is to disable the ACL executor for these parameters. Then OneDNN will run this case in ACL backend as reorder -> NHWC -> reorder and combination NHWC + CEIL without accuracy drop.