tools/downloader: align namespace

[jkamelin]

This PR is to align OMZ tools namespace in OpenVINO Python environment. The tools will now be located under openvino.model_zoo namespace and accessible through command line as omz_downloader, omz_converter, omz_quantizer, omz_data_downloader and omz_info_dumper commands, just like it is in openvino-dev PyPi package starting from OpenVINO 2021.4 release

[vladimir-dudnik]

@nignatovsky we probably need to make change in jenkins job to replace direct call to downloader.py with install it and call to omz_downloader ?

@jkamelin what do you think?

[jkamelin]

@nignatovsky we probably need to make change in jenkins job to replace direct call to downloader.py with install it and call to omz_downloader ?

@jkamelin what do you think?

I agree

[nignatovsky]

@nignatovsky we probably need to make change in jenkins job to replace direct call to downloader.py with install it and call to omz_downloader ?

@jkamelin what do you think?

Yes, I will make necessary changes in the Downloader job

[helena-intel]

It is very welcome that the names are now aligned between pip and other installers! The README still seems to assume that a user needs to install open model zoo. Could it be clarified that that step is not necessary if a user already installed OpenVINO with pip, or OMZ tools with IRC? I find it useful to refer to the OMZ tools README for usage info about the tools (and people may arrive their when searching for how to use, say, omz_quantizer, but that installation step may lead people to think that they still have to do these steps too.

Also, not essential but IMO it would be nicer if the README was not under /tools/downloader/README. It suggests that it is mostly about downloader, instead of all the OMZ tools. Is it being considered to change that, now that these relatively big changes are being made?

[helena-intel]

These instructions are for Ubuntu only. On Windows, if you install Python with the installer from python.org (the recommended way to install Python on Windows), setuptools and pip are included (though they are not always at the latest version). But if you type python3 in a command prompt, you get redirected to the Windows Store to install Python. So on Windows you have to type python, but on Ubuntu, you have to type python3.

This is how the PyPI openvino-dev install docs do this: https://github.com/openvinotoolkit/openvino/blob/master/docs/install_guides/pypi-openvino-dev.md
For the notebooks we recommend a virtualenv and have different headings https://github.com/openvinotoolkit/openvino_notebooks/

[jkamelin]

Changed command to python, added note about the difference on Linux

[jkamelin]

It is very welcome that the names are now aligned between pip and other installers! The README still seems to assume that a user needs to install open model zoo. Could it be clarified that that step is not necessary if a user already installed OpenVINO with pip, or OMZ tools with IRC? I find it useful to refer to the OMZ tools README for usage info about the tools (and people may arrive their when searching for how to use, say, omz_quantizer, but that installation step may lead people to think that they still have to do these steps too.

Added note that OMZ tools can be installed as a part of OpenVINO and provided installation steps are used to install from source.

Also, not essential but IMO it would be nicer if the README was not under /tools/downloader/README. It suggests that it is mostly about downloader, instead of all the OMZ tools. Is it being considered to change that, now that these relatively big changes are being made?

Renamed folder /tools/downloader/ to /tools/model_tools/

[slyubimt]

BTW, do we need to update documentation for openvino-dev package about a new tool omz_data_downloader?
https://github.com/openvinotoolkit/openvino/blob/master/docs/install_guides/pypi-openvino-dev.md

[jkamelin]

Yes

[vladimir-dudnik]

@jkamelin precommit check failed
12:42:28 tools/accuracy_checker/accuracy_checker/annotation_converters/README.md: unknown/disallowed HTML element in ''
12:42:28 tools/accuracy_checker/accuracy_checker/annotation_converters/README.md: unknown/disallowed HTML element in ''

just rebase, I think @eaidova has fixed this in #2736

[vladimir-dudnik]

@nignatovsky note, this PR also affect Demo validation job

[helena-intel]

What happens if a user installed OMZ according to the installation instructions and then a few months later installs openvino-dev, with a newer release? Is there a risk that their omz_downloader etc. then still points to a local directory (because that is earlier in the PATH) @slyubimt ? And is there a risk that things break in that case?

[slyubimt]

What happens if a user installed OMZ according to the installation instructions and then a few months later installs openvino-dev, with a newer release? Is there a risk that their omz_downloader etc. then still points to a local directory (because that is earlier in the PATH) @slyubimt ? And is there a risk that things break in that case?

If we consider the options to install both the packages, this one and openvino-dev, last installed overwrites aliases like omz_downloader.

[vladimir-dudnik]

Jenkins please retry a build

[ilya-lavrenov]

BTW, why scripts have name omz_downloader.py etc while they already in openvino.model_zoo? See https://github.com/jkamelin/open_model_zoo/tree/jk/namespace/tools/model_tools/src/openvino/model_zoo

[vladimir-dudnik]

@ilya-lavrenov names omz_downloader, omz_converter maintained for consistency with openvino-dev PyPi package in 2021.4. They will be called from command line in openvino-dev environment as omz_downloader. Names like simple downloader will look to generic in this case.

@jkamelin please rebase your branch

[vladimir-dudnik]

14:16:05 models/public/yolox-tiny/README.md: URL reference "../../../tools/downloader/README.md" target does not exist or is not a file

[vladimir-dudnik]

Jenkins please retry a build