[PT] bump torch to 2.5.1 #3037
Merged
[PT] bump torch to 2.5.1 #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
alexsu52
reviewed
Oct 24, 2024
daniil-lyakhov
approved these changes
Nov 4, 2024
alexsu52
reviewed
Nov 6, 2024
nikita-savelyevv
approved these changes
Nov 6, 2024
daniil-lyakhov
approved these changes
Nov 6, 2024
MaximProshin
reviewed
Nov 7, 2024
There was a problem hiding this comment.
@anzr299 , please list all the executed jobs with PT 2.5.0 and status.
Have you considered 2.5.1?
|
Consideration for Torch 2.5.1: Updated to torch 2.5.1 Status of Jobs
|
alexsu52
approved these changes
Nov 7, 2024
MaximProshin
approved these changes
Nov 7, 2024
nikita-savelyevv
pushed a commit
to nikita-savelyevv/nncf
that referenced
this pull request
Dec 11, 2024
### Changes 1. Change Torch Version from 2.4.0 -> 2.5.0 2. Update `nncf/experimental/torch/fx/transformations.py` for merging bias and linear/conv nodes to eliminate dead subgraph and nodes. Created `_get_connected_nodes()` to get the list of nodes directly or indirectly connected to the output node. 3. Import `torchvision` in NNCF patching for jit. 4. Update `MAP_BACKEND_PACKAGES` in `tests/cross_fw/shared/helpers.py` to include `torch` and `torchvision`. ### Reason for changes 1. Migration 2. Since the dead subgraphs and nodes were not being removed from the model after merging bias and conv/linear nodes, Only nodes which are directly or indirectly connected to the output node were kept. 3. This was done because import order with torchvision also affected the operators. 4. After change 3, it is required to pass `test_force_cuda_build` in `tests/torch/test_extensions_build.py`. ### Related tickets openvinotoolkit#3036 ### Tests `test_get_connected_nodes()` is added in `tests/torch/fx/test_model_transformer.py` to test `_get_connected_nodes()` function. ### Constrains Torch FX tests for windows are skipped (CVS-156781) since `torch._export.capture_pre_autograd_graph` does not support windows in torch 2.5 --------- Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
nncf/experimental/torch/fx/transformations.pyfor merging bias and linear/conv nodes to eliminate dead subgraph and nodes. Created_get_connected_nodes()to get the list of nodes directly or indirectly connected to the output node.torchvisionin NNCF patching for jit.MAP_BACKEND_PACKAGESintests/cross_fw/shared/helpers.pyto includetorchandtorchvision.Reason for changes
test_force_cuda_buildintests/torch/test_extensions_build.py.Related tickets
#3036
Tests
test_get_connected_nodes()is added intests/torch/fx/test_model_transformer.pyto test_get_connected_nodes()function.Constrains
Torch FX tests for windows are skipped (CVS-156781) since
torch._export.capture_pre_autograd_graphdoes not support windows in torch 2.5