Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore total of status bar #2606

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

kshpv
Copy link
Collaborator

@kshpv kshpv commented Mar 27, 2024

Changes

Restore total number of iterations for StatisticsAggregator after #2197

Reason for changes

N/A

Related tickets

136892

Tests

Manually tested on yolov8 sample for OV.
Before:
image

After:
image

@kshpv kshpv requested a review from a team as a code owner March 27, 2024 09:53
@kshpv kshpv requested a review from alexsu52 March 27, 2024 09:53
@github-actions github-actions bot added the NNCF Common Pull request that updates NNCF Common label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.91%. Comparing base (153d7e0) to head (30d908b).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2606      +/-   ##
===========================================
- Coverage    91.15%   84.91%   -6.25%     
===========================================
  Files          494      494              
  Lines        45387    45384       -3     
===========================================
- Hits         41373    38536    -2837     
- Misses        4014     6848    +2834     
Files Coverage Δ
nncf/common/tensor_statistics/aggregator.py 100.00% <100.00%> (ø)

... and 59 files with indirect coverage changes

Flag Coverage Δ
COMMON 44.13% <0.00%> (-0.02%) ⬇️
ONNX 34.66% <100.00%> (-0.01%) ⬇️
OPENVINO ∅ <ø> (∅)
TENSORFLOW 30.10% <0.00%> (-0.01%) ⬇️
TORCH 65.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.12% <100.00%> (-0.61%) ⬇️
torch 93.48% <ø> (+<0.01%) ⬆️
tensorflow 93.74% <ø> (ø)
onnx 93.09% <ø> (ø)
openvino 25.76% <ø> (-68.38%) ⬇️
ptq 69.92% <ø> (-20.20%) ⬇️

Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsu52 alexsu52 merged commit 06f8a1e into openvinotoolkit:develop Mar 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF Common Pull request that updates NNCF Common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants