Fix remove_shapeof_subgraphs #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-churkin
commented
Feb 29, 2024
| @@ -64,26 +64,26 @@ def remove_shapeof_subgraphs( | |||
| if node.metatype in shapeof_metatypes: | |||
| shape_of_nodes.append(node) | |||
| continue | |||
| if node in infer_nodes: | |||
| if node.node_name in infer_nodes: | |||
There was a problem hiding this comment.
@KodiaqQ These changes are necessary because a node from quantized_model_graph contains NumPy arrays in its attributes. Therefore, it is not possible to perform the NNCFNode.__eq__() method due to this comparison
self.attributes == other.attributesI have not changed NNCFNode.__eq__() method because these attributes are custom (they were added by algorithm).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2536 +/- ##
===========================================
- Coverage 90.92% 84.63% -6.29%
===========================================
Files 498 498
Lines 45550 45553 +3
===========================================
- Hits 41415 38555 -2860
- Misses 4135 6998 +2863
... and 55 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nikita-malininn
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason for changes
The
remove_shapeof_subgraphs()function removes some operations whose weights are quantized.Related tickets
Ref: 131843
Tests
Current scope