Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTQ] Fix ModeBasedDefaults #2487

Conversation

nikita-malininn
Copy link
Collaborator

Changes

  • Fix ModeBasedDefaults creation with fields;

Reason for changes

  • Bug with Python 3.11;

Related tickets

  • N/A

Tests

  • N/A

@github-actions github-actions bot added the NNCF PTQ Pull requests that updates NNCF PTQ label Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f812e88) 90.91% compared to head (f220509) 84.63%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2487      +/-   ##
===========================================
- Coverage    90.91%   84.63%   -6.28%     
===========================================
  Files          498      498              
  Lines        45508    45526      +18     
===========================================
- Hits         41372    38530    -2842     
- Misses        4136     6996    +2860     
Files Coverage Δ
nncf/quantization/algorithms/min_max/algorithm.py 95.23% <100.00%> (-1.96%) ⬇️

... and 57 files with indirect coverage changes

Flag Coverage Δ
COMMON 42.73% <100.00%> (+0.10%) ⬆️
ONNX 34.77% <100.00%> (+0.03%) ⬆️
OPENVINO ∅ <ø> (∅)
TENSORFLOW 29.66% <100.00%> (+<0.01%) ⬆️
TORCH 65.99% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.11% <ø> (-0.66%) ⬇️
torch 93.42% <ø> (+<0.01%) ⬆️
tensorflow 93.96% <ø> (ø)
onnx 93.05% <ø> (ø)
openvino 25.60% <ø> (-68.47%) ⬇️
ptq 67.32% <100.00%> (-20.35%) ⬇️

@nikita-malininn nikita-malininn marked this pull request as ready for review February 20, 2024 10:28
@nikita-malininn nikita-malininn requested a review from a team as a code owner February 20, 2024 10:28
@nikita-malininn nikita-malininn self-assigned this Feb 20, 2024
@nikita-malininn nikita-malininn merged commit 6b0ba7a into openvinotoolkit:develop Feb 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants