Remove redundant ONNX samples and split requirements #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
|
run build |
aiarkinx
reviewed
Nov 29, 2022
Makefile
Outdated
| @@ -15,3 +15,6 @@ pylint-onnx: | |||
| nncf/experimental/onnx \ | |||
| nncf/quantization \ | |||
| tests/onnx examples/experimental/onnx | |||
|
|
|||
| test-install-onnx: | |||
| pytest tests/cross_fw/install/test_install.py --backend onnx | |||
There was a problem hiding this comment.
Should we specify a folder (tests/cross_fw/install/) but not a test_install.py file?
alexsu52
reviewed
Nov 30, 2022
vshampor
approved these changes
Nov 30, 2022
aiarkinx
approved these changes
Nov 30, 2022
nikita-malininn
approved these changes
Nov 30, 2022
andrey-churkin
approved these changes
Dec 1, 2022
alexsu52
pushed a commit
to alexsu52/nncf
that referenced
this pull request
Dec 7, 2022
…#1392) ### Changes Split ONNX requirements. Remove redundant examples for ONNX Add a check for ONNX part installation of NNCF. ### Reason for changes 96933 ### Related tickets 96933 ### Tests Add install_checks_onnx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Split ONNX requirements.
Remove redundant examples for ONNX
Add a check for ONNX part installation of NNCF.
Reason for changes
96933
Related tickets
96933
Tests
Add install_checks_onnx