Joint Pruning, Quantization and Distillation for Transformers - #1319
Merged
Conversation
vuiseng9
commented
Oct 14, 2022
vuiseng9
commented
Oct 14, 2022
vuiseng9
commented
Oct 14, 2022
vuiseng9
commented
Oct 14, 2022
vuiseng9
commented
Oct 14, 2022
vuiseng9
commented
Oct 14, 2022
vuiseng9
commented
Oct 14, 2022
vuiseng9
commented
Oct 14, 2022
vuiseng9
commented
Oct 14, 2022
ljaljushkin
reviewed
Oct 14, 2022
ljaljushkin
left a comment
Contributor
There was a problem hiding this comment.
Some initial comments
vuiseng9
commented
Oct 19, 2022
ljaljushkin
reviewed
Oct 28, 2022
ljaljushkin
reviewed
Nov 2, 2022
vuiseng9
commented
Nov 3, 2022
vuiseng9
commented
Nov 3, 2022
vuiseng9
commented
Nov 5, 2022
Contributor
Author
|
@yujiepan-work fyi #1354 and #1323 pertaining to the onnx export. |
vuiseng9
commented
Nov 12, 2022
ljaljushkin
suggested changes
Nov 17, 2022
ljaljushkin
left a comment
Contributor
There was a problem hiding this comment.
Overall, great job and test coverage! Only have some minor comments.
vuiseng9
force-pushed
the
p4-jpqd-dev
branch
from
November 18, 2022 00:48
e392716 to
b1ed72d
Compare
Contributor
|
run pytorch pre-commit tests |
ljaljushkin
reviewed
Nov 29, 2022
* clean unnecessary codes * implement ada threshold with torch api rather than numpy api * pylint fix * simplify sparsity report * change loss calculation implementation * remove Enum.from_str * change logging level * add copyright * change scheduler param default value * rename * use single quote for strings * fix circulant import * add some docstrings * pylint fix
* documentation part1 * minor change
…ame example folder (#28)
* fix jit inplace * add softmax before checking onnx outputs * scheduler param dataclass * delete recipe "set" shortcut * rename * rename "linear_layer_sparsity"
vuiseng9
force-pushed
the
p4-jpqd-dev
branch
from
December 16, 2022 17:31
0e7927e to
5169166
Compare
…follow regularization warmup shape
* add test about "calc_init_threshold" called once * add tests about no weight override on model export * ensure compression loss is always torch.Tensor even if disabled * pylint fix * rename `sparse_layer` into `operand` * complete class and function docstrings * minor fix * add new lines to improve readability * use shared `nncf_caplog` instead of a self-implemented one * beautify `TestAutogradFunction` * use fixture to skip autograd tests when cuda is not available * delete markdown file dump for structured sparsity report * schema uses CONST_VARIABLE for default * change scheduler param order * refactor recipe (part1) * refactor recipe (part 2) * refactor recipe (part3) * refactor recipe (part4) * minor format changes * change training script path to a constant variable * rename "linear layer sparsity" in documentation * typo * change BuildingBlockType hash to hash(self.name) * add tests about compression state save & resume * fix wrong use of PTTensorListComparator in `test_can_load_state_dict` * fix bug that importance weights are still updated after warmup (due to adam characteristic) * bugfix in PTTensorListComparator in `test_can_load_state_dict` * rename `test_calc_init_threshold_called_once` * Split `TestModelSaving` to a standalone file * avoid triple ")" in codes for better readability * rename `structured_mask_context_list` to `structured_mask_contexts` * adjust argument name in `test_can_resume_training_from_compression_state`
ljaljushkin
approved these changes
Dec 19, 2022
AlexanderDokuchaev
approved these changes
Dec 19, 2022
vshampor
approved these changes
Dec 19, 2022
Contributor
|
Missed a couple of my comments, but nothing critical at this stage. I have put in the approval. |
AlexKoff88
approved these changes
Dec 19, 2022
This comment was marked as resolved.
This comment was marked as resolved.
* add missing docstring for `StructuredMaskContextGroup` and minor changes in other docstings * fix typo in documentation * add docstring for StructuredMaskContextStatistics * temporarily remove claim of fractional warmup start/end epoch
* pylint fix * documentation: require steps_per_epoch when warmup starts at "epoch in [0,1)" -> "at first epoch"
yujiepan-work
approved these changes
Dec 19, 2022
Contributor
|
run tensorflow pre-commit tests |
ljaljushkin
approved these changes
Dec 19, 2022
ljaljushkin
left a comment
Contributor
There was a problem hiding this comment.
The latest minor changes in the documentation look good to me.
There was TF pre-commit failure, but seems like there's some sporadic issue. After re-run the validation is green.
ljaljushkin
added a commit
to ljaljushkin/nncf_pytorch
that referenced
this pull request
Dec 23, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add movement pruning feature, enabling end-to-end compression for transformer inference acceleration via OpenVINO
Reason for changes
Related tickets
Tests
Some basic tests are included, team will continue to refactor, add tests to this pull request.