Skip to content

Coverity rule of 4 #3803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkalinowski wants to merge 5 commits into
base: main
Choose a base branch
from
+15 −0
Open

Coverity rule of 4 #3803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
48b64fe
save
dkalinowski Nov 18, 2025
f3deff7
Merge remote-tracking branch 'origin/main' into coverity5
dkalinowski Dec 8, 2025
ec7f1e3
save
dkalinowski Dec 8, 2025
6e14cfa
Merge remote-tracking branch 'origin/main' into coverity5
dkalinowski Feb 6, 2026
120ec6e
save
dkalinowski Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/http_rest_api_handler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,6 +693,12 @@ struct V3StreamCallbackResourceGuard {
CopyableObjectWrapper<HttpPayload>& requestWrapper;
std::shared_ptr<HttpAsyncWriter>& serverReaderWriter;

V3StreamCallbackResourceGuard() = delete;
V3StreamCallbackResourceGuard(const V3StreamCallbackResourceGuard&) = delete;
V3StreamCallbackResourceGuard& operator=(const V3StreamCallbackResourceGuard&) = delete;
V3StreamCallbackResourceGuard& operator=(V3StreamCallbackResourceGuard&&) = delete;
V3StreamCallbackResourceGuard(V3StreamCallbackResourceGuard&&) = delete;

V3StreamCallbackResourceGuard(
CopyableObjectWrapper<MediapipeGraphExecutor>& executorWrapper,
CopyableObjectWrapper<HttpPayload>& requestWrapper,
Expand Down
9 changes: 9 additions & 0 deletions src/server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,12 +430,21 @@ class ModulesShutdownGuard {
~ModulesShutdownGuard() {
this->server.shutdownModules();
}
ModulesShutdownGuard(const ModulesShutdownGuard&) = delete;
ModulesShutdownGuard& operator=(const ModulesShutdownGuard&) = delete;
ModulesShutdownGuard(ModulesShutdownGuard&&) = delete;
ModulesShutdownGuard& operator=(ModulesShutdownGuard&&) = delete;
};

class OvmsExitGuard {
Server& server;

public:
OvmsExitGuard() = delete;
OvmsExitGuard(const OvmsExitGuard&) = delete;
OvmsExitGuard& operator=(const OvmsExitGuard&) = delete;
OvmsExitGuard& operator=(OvmsExitGuard&&) = delete;
OvmsExitGuard(OvmsExitGuard&&) = delete;
Comment on lines +446 to +447
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of deleted special member functions is inconsistent. The move assignment operator appears before the move constructor, while in ModulesShutdownGuard the move constructor appears before the move assignment operator. For consistency and readability, follow the canonical order: copy constructor, copy assignment, move constructor, move assignment.

Suggested change
OvmsExitGuard& operator=(OvmsExitGuard&&) = delete;
OvmsExitGuard(OvmsExitGuard&&) = delete;
OvmsExitGuard(OvmsExitGuard&&) = delete;
OvmsExitGuard& operator=(OvmsExitGuard&&) = delete;

Copilot uses AI. Check for mistakes.
OvmsExitGuard(Server& server) :
server(server) { server.setExitStatus(0); }
~OvmsExitGuard() { server.setExitStatus(1); }
Expand Down