Skip to content

fix-response-parser-unit-tests#3439

Draft
pgladkows wants to merge 15 commits intomainfrom
fix-response-parser-unit-tests
Draft

fix-response-parser-unit-tests#3439
pgladkows wants to merge 15 commits intomainfrom
fix-response-parser-unit-tests

Conversation

@pgladkows
Copy link
Collaborator

🛠 Summary

JIRA/Issue if applicable.
Describe the changes.

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

@pgladkows pgladkows force-pushed the fix-response-parser-unit-tests branch from 6ef73ee to a6eea7c Compare June 24, 2025 15:27
@pgladkows pgladkows marked this pull request as ready for review June 25, 2025 09:58
@pgladkows pgladkows requested review from dtrawins and mzegla June 25, 2025 10:49
@pgladkows pgladkows force-pushed the fix-response-parser-unit-tests branch 2 times, most recently from 914b64e to 3e70273 Compare June 25, 2025 11:50
@pgladkows pgladkows marked this pull request as draft June 25, 2025 12:02
@pgladkows pgladkows force-pushed the fix-response-parser-unit-tests branch 10 times, most recently from 62713ce to 1b09c5d Compare June 25, 2025 16:20
@mzegla mzegla requested a review from Copilot June 26, 2025 08:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the run_unit_tests workflow by adding support for mounting LLM and OVMS model directories into the test container.

  • Defines MNT_LLM_MODELS_PATH and OVMS_MODELS_PATH for host model locations
  • Adds a prepare_container_mounts target to build conditional Docker volume flags
  • Updates run_unit_tests to depend on the new target and include the mounts
Comments suppressed due to low confidence (3)

Makefile:86

  • Consider adding a comment or updating documentation (e.g., in the README) to explain what MNT_LLM_MODELS_PATH should point to and when it should be customized.
MNT_LLM_MODELS_PATH ?= "/mnt/llm_models"

Makefile:87

  • The hard-coded default path /opt/home/k8sworker/ovms_models is environment-specific; consider parameterizing this further or validating its existence at runtime to improve portability.
OVMS_MODELS_PATH ?= "/opt/home/k8sworker/ovms_models"

Makefile:659

  • Add prepare_container_mounts to the .PHONY target list to ensure Make treats it as a recipe and not a file name.
prepare_container_mounts:

@pgladkows pgladkows force-pushed the fix-response-parser-unit-tests branch from 335399b to 2a18f33 Compare July 8, 2025 14:32
@pgladkows pgladkows removed the request for review from dtrawins July 28, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants