Draft
Conversation
6ef73ee to
a6eea7c
Compare
mzegla
reviewed
Jun 25, 2025
914b64e to
3e70273
Compare
62713ce to
1b09c5d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the run_unit_tests workflow by adding support for mounting LLM and OVMS model directories into the test container.
- Defines
MNT_LLM_MODELS_PATHandOVMS_MODELS_PATHfor host model locations - Adds a
prepare_container_mountstarget to build conditional Docker volume flags - Updates
run_unit_teststo depend on the new target and include the mounts
Comments suppressed due to low confidence (3)
Makefile:86
- Consider adding a comment or updating documentation (e.g., in the README) to explain what
MNT_LLM_MODELS_PATHshould point to and when it should be customized.
MNT_LLM_MODELS_PATH ?= "/mnt/llm_models"
Makefile:87
- The hard-coded default path
/opt/home/k8sworker/ovms_modelsis environment-specific; consider parameterizing this further or validating its existence at runtime to improve portability.
OVMS_MODELS_PATH ?= "/opt/home/k8sworker/ovms_models"
Makefile:659
- Add
prepare_container_mountsto the.PHONYtarget list to ensure Make treats it as a recipe and not a file name.
prepare_container_mounts:
335399b to
2a18f33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``