Skip to content

Handle Fault when fetching GetSnapshotUri #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Handle Fault when fetching GetSnapshotUri #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions onvif/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,14 +506,23 @@ async def get_snapshot_uri(self, profile_token: str) -> str:
media_service = await self.create_media_service()
req = media_service.create_type("GetSnapshotUri")
req.ProfileToken = profile_token
result = await media_service.GetSnapshotUri(req)
uri = None
try:
uri = normalize_url(result.Uri)
except KeyError:
result = await media_service.GetSnapshotUri(req)
except zeep.exceptions.Fault as error:
logger.warning(
"%s: The device returned an invalid snapshot URI", self.host
"%s: Failed to get snapshot URI for profile %s: %s",
self.host,
profile_token,
error,
)
uri = None
else:
try:
uri = normalize_url(result.Uri)
except KeyError:
logger.warning(
"%s: The device returned an invalid snapshot URI", self.host
)
self._snapshot_uris[profile_token] = uri
return uri

Expand Down