Fix OCI repository URL resolution to prevent duplicate name fragments #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: knqyf263 <knqyf263@gmail.com>
9 tasks
Signed-off-by: knqyf263 <knqyf263@gmail.com>
knqyf263
force-pushed
the
fix/oci_repository_url
branch
from
3c99dd5
to
fc98ca6
Compare
|
I'm sorry I found a mistake and fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue with the current implementation of OCI PURL repository URL resolution. According to the PURL specification, for the
ocitype, the 'name' should be the last fragment of the repository name, and it should not be unnecessarily appended to the repository URL.Current behavior:
For a PURL like
pkg:oci/debian@sha256%3A244fd47e07d10?repository_url=ghcr.io/debian&tag=bullseyeThe implementation incorrectly resolves the repository URL to: ghcr.io/debian/debian:bullseye
Desired behavior:
The repository URL should resolve to: ghcr.io/debian:bullseye
Please correct me if I'm missing something. Thanks.