Fix flaky test_jsum_list_of_lists bfloat16 test#517
Merged
Conversation
Add @probabilistic_test decorator to test_jsum_list_of_lists, matching the pattern already used by test_jsum. The bfloat16 numerical precision can cause non-deterministic allclose failures when comparing jsum against scatter_sum. The decorator runs 20 iterations and passes if >= 80% succeed, which is the same strategy used for the flat-list variant. Signed-off-by: Francis Williams <francis@fwilliams.info> Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@probabilistic_testdecorator totest_jsum_list_of_lists, matching the pattern already used bytest_jsumallclosefailures when comparingjsumagainstscatter_sumThis was observed as a transient CI failure on the V0.4 release branch (PR #515).
Test plan
test_jsum_list_of_lists_1_cuda(bfloat16) no longer flakesMade with Cursor