Improve envelope logic#2262
Open
maiko3tattun wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert preutter limit for VC
In ver 0.1.568, there were no restrictions on preutter.
Since PR Apply track settings (vel, clr, tone shift, alt) to all phonemizers #2236 introduced a 90% limit on preutter, so I'm reverting it back to 100% in this PR.
Ensure minimum length for VC envelope
Due to the change above, the length between point 2 (VC position) and point 4 (end of fade-out) becomes 0 when overlap is 0. I added a 5ms minimum to this section to prevent it from disappearing.