Simplify and update overscroll explainer - #1503
Open
vmpstr wants to merge 1 commit into
Open
Conversation
vmpstr
requested review from
gregwhitworth,
keithamus,
lukewarlow and
mfreed7
as code owners
August 13, 2026 19:12
mfreed7
approved these changes
Aug 17, 2026
mfreed7
left a comment
mfreed7
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Just some small stuff.
|
|
||
| When the overscroll area is visible, the overscroll area has an | ||
| `:overscroll-backdrop` pseudo element that is styled by default with a | ||
| semi-transparent cover, similar to a dialog `:backdrop`. This includes a |
| </div> | ||
| ``` | ||
|
|
||
| ### Swipe to dismiss |
Collaborator
There was a problem hiding this comment.
Can this one not stay, perhaps with the addition of an "X" in the corner to be the button?
| main page, it is a clear signal they are done, making `blur` a safe and helpful | ||
| trigger to automatically close them. | ||
|
|
||
| ## Modalness |
Collaborator
There was a problem hiding this comment.
So it seems like actually ALL of the remaining demos (the menu) are modal, is that right? Perhaps some part of the modality conversation should be left in?
Also this removed the conversation about focus loss, which I see is mostly moot if the menu is modal. But perhaps good to be explicit that focus loss isn't a light dismiss signal? (It's still possible, by focusing out of the web content into the browser UI.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.