Skip to content

UCM/TEST: Generate VM_UNMAP event for shmat(REMAP) and mmap(FIXED) #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 26, 2018
Merged

UCM/TEST: Generate VM_UNMAP event for shmat(REMAP) and mmap(FIXED) #2703

merged 4 commits into from
Jun 26, 2018

Conversation

@yosefe
Copy link
Contributor

@yosefe yosefe commented Jun 24, 2018

No description provided.

@yosefe
UCM/TEST: Generate VM_UNMAP event for shmat(REMAP) and mmap(FIXED)
dccbc0f 
These 2 calls can override an existing memory mapping, so generate a
VM_UNMAP event for the old address range.
@yosefe
Copy link
Contributor Author

yosefe commented Jun 24, 2018

adding @bureddy

@yosefe yosefe added the Bugfix label Jun 24, 2018
@swx-jenkins1
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/4855/ for details.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/7244/ for details (Mellanox internal link).

@bureddy
Copy link
Contributor

bureddy commented Jun 24, 2018

bot:retest

@swx-jenkins1
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/4856/ for details.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/7245/ for details (Mellanox internal link).

@swx-jenkins1
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/4858/ for details.

@yosefe yosefe force-pushed the topic/ucm-vm-unmap-on-override branch from 1a9159b to 8ea0814 Compare June 25, 2018 10:38
@swx-jenkins1
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/4859/ for details.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/7247/ for details (Mellanox internal link).

@mellanox-github
Copy link
Contributor

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/7248/ for details (Mellanox internal link).

@swx-jenkins1
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/4860/ for details.

@mellanox-github
Copy link
Contributor

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/7249/ for details (Mellanox internal link).

@yosefe
Copy link
Contributor Author

yosefe commented Jun 26, 2018

@hoopoepg pls take a look

hoopoepg
hoopoepg approved these changes Jun 26, 2018
View reviewed changes
test/gtest/ucs/test_async.cc
UCS_TEST_P(test_async, many_timers) {

for (int count = 0; count < 1000; ++count) {
for (int count = 0; count < 4010; ++count) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magic numbers? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to reach the limit of id's with the previous (buggy) implementation

@yosefe yosefe merged commit 414be8d into openucx:master Jun 26, 2018
@yosefe yosefe deleted the topic/ucm-vm-unmap-on-override branch June 26, 2018 08:07
@yosefe yosefe mentioned this pull request Jun 26, 2018
Merged
markalle added a commit to markalle/ompi that referenced this pull request Mar 27, 2019
@markalle
shmat/shmdt additions for patcher
9e4654d 
This is mostly based off recent UCX additions to their patcher:
    openucx/ucx#2703

They added triggers for
* mmap when (flags & MAP_FIXED) && (addr != NULL)
* shmat when (shmflg & SHM_REMAP) && (shmaddr != NULL)

Beyond that I noticed they already had a trigger for
* madvise when (advice == MADV_FREE)
that we didn't so I added that.

And the other main thing is we didn't really have shmat/shmdt
active for some systems because we only had a path for
syscall(SYS_shmdt, ) but we needed to also have a path for
syscall(SYS_ipc, IPCOP_shmdt, ) and same for shmat.

Signed-off-by: Mark Allen <markalle@us.ibm.com>
@markalle markalle mentioned this pull request Mar 27, 2019
Merged
markalle added a commit to markalle/ompi that referenced this pull request Mar 29, 2019
@markalle
shmat/shmdt additions for patcher
eb88811 
This is mostly based off recent UCX additions to their patcher:
    openucx/ucx#2703

They added triggers for
* mmap when (flags & MAP_FIXED) && (addr != NULL)
* shmat when (shmflg & SHM_REMAP) && (shmaddr != NULL)

Beyond that I noticed they already had a trigger for
* madvise when (advice == MADV_FREE)
that we didn't so I added that.

And the other main thing is we didn't really have shmat/shmdt
active for some systems because we only had a path for
syscall(SYS_shmdt, ) but we needed to also have a path for
syscall(SYS_ipc, IPCOP_shmdt, ) and same for shmat.

Signed-off-by: Mark Allen <markalle@us.ibm.com>
markalle added a commit to markalle/ompi that referenced this pull request May 30, 2019
@markalle
shmat/shmdt additions for patcher
5f79dfa 
This is mostly based off recent UCX additions to their patcher:
    openucx/ucx#2703

They added triggers for
* mmap when (flags & MAP_FIXED) && (addr != NULL)
* shmat when (shmflg & SHM_REMAP) && (shmaddr != NULL)

Beyond that I noticed they already had a trigger for
* madvise when (advice == MADV_FREE)
that we didn't so I added that.

And the other main thing is we didn't really have shmat/shmdt
active for some systems because we only had a path for
syscall(SYS_shmdt, ) but we needed to also have a path for
syscall(SYS_ipc, IPCOP_shmdt, ) and same for shmat.

Signed-off-by: Mark Allen <markalle@us.ibm.com>
(cherry picked from commit eb88811)
markalle added a commit to markalle/ompi that referenced this pull request May 30, 2019
@markalle
shmat/shmdt additions for patcher
8be0a23 
This is mostly based off recent UCX additions to their patcher:
    openucx/ucx#2703

They added triggers for
* mmap when (flags & MAP_FIXED) && (addr != NULL)
* shmat when (shmflg & SHM_REMAP) && (shmaddr != NULL)

Beyond that I noticed they already had a trigger for
* madvise when (advice == MADV_FREE)
that we didn't so I added that.

And the other main thing is we didn't really have shmat/shmdt
active for some systems because we only had a path for
syscall(SYS_shmdt, ) but we needed to also have a path for
syscall(SYS_ipc, IPCOP_shmdt, ) and same for shmat.

Signed-off-by: Mark Allen <markalle@us.ibm.com>
(cherry picked from commit eb88811)
markalle added a commit to markalle/ompi that referenced this pull request May 30, 2019
@markalle
shmat/shmdt additions for patcher
099fb5b 
This is mostly based off recent UCX additions to their patcher:
    openucx/ucx#2703

They added triggers for
* mmap when (flags & MAP_FIXED) && (addr != NULL)
* shmat when (shmflg & SHM_REMAP) && (shmaddr != NULL)

Beyond that I noticed they already had a trigger for
* madvise when (advice == MADV_FREE)
that we didn't so I added that.

And the other main thing is we didn't really have shmat/shmdt
active for some systems because we only had a path for
syscall(SYS_shmdt, ) but we needed to also have a path for
syscall(SYS_ipc, IPCOP_shmdt, ) and same for shmat.

Signed-off-by: Mark Allen <markalle@us.ibm.com>
(cherry picked from commit eb88811)
@markalle markalle mentioned this pull request May 30, 2019
Merged
This was referenced May 30, 2019
Merged
Merged
markalle added a commit to markalle/ompi that referenced this pull request Sep 12, 2020
@markalle
shmat/shmdt additions for patcher
1800d3b 
This is mostly based off recent UCX additions to their patcher:
    openucx/ucx#2703

They added triggers for
* mmap when (flags & MAP_FIXED) && (addr != NULL)
* shmat when (shmflg & SHM_REMAP) && (shmaddr != NULL)

Beyond that I noticed they already had a trigger for
* madvise when (advice == MADV_FREE)
that we didn't so I added that.

And the other main thing is we didn't really have shmat/shmdt
active for some systems because we only had a path for
syscall(SYS_shmdt, ) but we needed to also have a path for
syscall(SYS_ipc, IPCOP_shmdt, ) and same for shmat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hoopoepg hoopoepg hoopoepg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yosefe @swx-jenkins1 @mellanox-github @bureddy @hoopoepg