Skip to content

Conversation

@ILOVEPIE
Copy link
Contributor

@ILOVEPIE ILOVEPIE commented Feb 2, 2023

Description

This PR redoes the names table handling to preserve platform specific naming schemes for fonts.

Motivation and Context

I have a project that depends on this working correctly. This closes issue #527.

How Has This Been Tested?

All test cases pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I did npm run test and all tests passed green (including code styling checks).
  • I have added tests to cover my changes.
  • I have updated the README accordingly.
  • I have read the CONTRIBUTING document.

@ILOVEPIE
Copy link
Contributor Author

ILOVEPIE commented Feb 2, 2023

@Connum sorry, can you re-do your review on this repository.

@ILOVEPIE ILOVEPIE requested a review from Connum February 2, 2023 21:49
Copy link
Contributor

@Connum Connum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I didn't have access to the former review, I did it again quickly - hope I caught everything! :)

@ILOVEPIE ILOVEPIE requested a review from Connum February 2, 2023 23:33
@ILOVEPIE ILOVEPIE force-pushed the preservePlatformNames branch from dbae15d to 673eb59 Compare February 2, 2023 23:43
@ILOVEPIE
Copy link
Contributor Author

ILOVEPIE commented Feb 3, 2023

@Connum when you get the time, I've updated it to the latest master and fixed those issues you mentioned, needs another review.

@Connum
Copy link
Contributor

Connum commented Feb 3, 2023

I noticed that the changes break the font inspector when running npm run start. I made a PR in your branch to fix this.

@ILOVEPIE ILOVEPIE requested a review from Connum February 5, 2023 03:05
@ILOVEPIE ILOVEPIE force-pushed the preservePlatformNames branch 2 times, most recently from f042f7c to 8e7449f Compare February 5, 2023 06:10
Copy link
Contributor

@Connum Connum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ILOVEPIE ILOVEPIE requested a review from Connum February 5, 2023 09:48
@ILOVEPIE
Copy link
Contributor Author

ILOVEPIE commented Feb 5, 2023

Just need this to be signed off again, as I bumped the version to 2.0.0 because of the breaking change. @Connum

@yne
Copy link
Contributor

yne commented Feb 26, 2023

@ILOVEPIE Could you share the google-closure-compiler command line you used ?

I can't find a way to run it without heavily modifying the opentype.js source code

@ILOVEPIE
Copy link
Contributor Author

@yne I didn't use closure compiler on opentype.js, that externs file is a file that is used by other projects to inform their closure compiler as to what functions/types/properties opentype.js exposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants