-
Notifications
You must be signed in to change notification settings - Fork 517
Preserve platform specific names in fonts. #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Connum sorry, can you re-do your review on this repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I didn't have access to the former review, I did it again quickly - hope I caught everything! :)
dbae15d to
673eb59
Compare
|
@Connum when you get the time, I've updated it to the latest master and fixed those issues you mentioned, needs another review. |
|
I noticed that the changes break the font inspector when running |
f042f7c to
8e7449f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Just need this to be signed off again, as I bumped the version to 2.0.0 because of the breaking change. @Connum |
|
@ILOVEPIE Could you share the I can't find a way to run it without heavily modifying the opentype.js source code |
|
@yne I didn't use closure compiler on opentype.js, that externs file is a file that is used by other projects to inform their closure compiler as to what functions/types/properties opentype.js exposes. |
Description
This PR redoes the names table handling to preserve platform specific naming schemes for fonts.
Motivation and Context
I have a project that depends on this working correctly. This closes issue #527.
How Has This Been Tested?
All test cases pass.
Types of changes
Checklist:
npm run testand all tests passed green (including code styling checks).