Add missing SIRI ET module tests for modified trips#7294
Merged
leonardehrenfried merged 3 commits intoopentripplanner:dev-2.xfrom Feb 23, 2026
Merged
Conversation
vpaturet
added
!Technical Debt
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7294 +/- ##
=============================================
- Coverage 72.20% 70.33% -1.88%
+ Complexity 21319 20497 -822
=============================================
Files 2323 2324 +1
Lines 86066 85920 -146
Branches 8554 8524 -30
=============================================
- Hits 62141 60428 -1713
- Misses 20915 22515 +1600
+ Partials 3010 2977 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add 8 tests covering common real-world use cases for the SIRI ET updater's ModifiedTripBuilder and handleModifiedTrip flow: - Mixed recorded + estimated calls (most common SIRI pattern) - Successive updates replacing previous delays - Cancel all stops triggering implicit trip cancellation - Multi-trip pattern isolation (update one, leave other unaffected) - Journey-level occupancy propagation - Prediction inaccurate flag propagation - Updating times on a previously added (replacement) trip - Quay change then revert to original stops Also adds withOccupancy() and withPredictionInaccurate() builder methods to SiriEtBuilder for test support.
vpaturet
force-pushed
the
siri-et-module-tests-modified-trips
branch
from
c36557b to
ae5f7e8
Compare
leonardehrenfried
previously approved these changes
Feb 13, 2026
# Conflicts: # application/src/test/java/org/opentripplanner/updater/trip/siri/moduletests/extrajourney/ExtraJourneyTest.java
leonardehrenfried
previously approved these changes
Feb 13, 2026
habrahamsson-skanetrafiken
requested changes
Feb 13, 2026
| .addStop(STOP_B, "0:00:20", "0:00:21"); | ||
|
|
||
| @Test | ||
| void testCancelAllStopsCancelsTrip() { |
Contributor
There was a problem hiding this comment.
Document that it's unsure if this is the behaviour that we want.
vpaturet
requested review from
habrahamsson-skanetrafiken and
leonardehrenfried
vpaturet
force-pushed
the
siri-et-module-tests-modified-trips
branch
from
4fde300 to
9339ea4
Compare
habrahamsson-skanetrafiken
approved these changes
Feb 23, 2026
leonardehrenfried
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 8 tests covering use cases for SIRI ET modified trips:
Also adds withOccupancy() and withPredictionInaccurate() builder methods to SiriEtBuilder for test support.
Issue
No
Unit tests
Added unit tests.
Documentation
No
Changelog
skip