Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax rejection of GTFS flex trips that also contain continuous stopping #6231

Open
wants to merge 6 commits into
base: dev-2.x
Choose a base branch
from

Conversation

leonardehrenfried
Copy link
Member

Summary

This brings OTP in line with the GTFS spec by allowing flex and continuous stopping in the same trip as long as it's not mixed in the very same stop time.

There is also a small improvement to the debug UI where routes without a publicCode/shortName use the long name as the fallback.

Issue

Closes #6230

Unit tests

The majority of the code is test refactoring. Lots of tests for this behavior added.

Documentation

n/a

Bumping the serialization version id

I'm changing static method on a file that is being serialised so I'm bumping just in case.

@leonardehrenfried leonardehrenfried added Bug TriMet GTFS Related to import of GTFS data IBI Developed by or important for IBI Group labels Nov 5, 2024
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner November 5, 2024 16:51
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.75%. Comparing base (87b6a46) to head (8f6ba7b).

Files with missing lines Patch % Lines
.../org/opentripplanner/ext/flex/FlexTripsMapper.java 50.00% 0 Missing and 1 partial ⚠️
...ipplanner/ext/flex/trip/ScheduledDeviatedTrip.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6231      +/-   ##
=============================================
- Coverage      69.75%   69.75%   -0.01%     
  Complexity     17652    17652              
=============================================
  Files           2007     2007              
  Lines          75563    75561       -2     
  Branches        7731     7730       -1     
=============================================
- Hits           52711    52707       -4     
- Misses         20141    20146       +5     
+ Partials        2711     2708       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried
Copy link
Member Author

@m-mcqueen @fpurcell If you want to you can try out this version and deploy it to your servers before review has concluded.

@leonardehrenfried leonardehrenfried added the bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR GTFS Related to import of GTFS data IBI Developed by or important for IBI Group TriMet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rejection of continuous stopping in flex trips is overly strict
1 participant