Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup of operator stuff in TransitModel #6143

Conversation

habrahamsson-skanetrafiken
Copy link
Contributor

Summary

  • Add specific method for adding operators.
  • Make operator list unmodifiable.
  • Remove TransitService.getOperators() since we already have TransitService.getAllOperators().

Issue

#6048

Unit tests

No tests for this.

Bumping the serialization version id

I'm changing the signature of TransitModel.

@habrahamsson-skanetrafiken habrahamsson-skanetrafiken added bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR Skip Changelog labels Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.83%. Comparing base (9e58db4) to head (014824b).
Report is 127 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6143      +/-   ##
=============================================
- Coverage      69.85%   69.83%   -0.02%     
- Complexity     17491    17665     +174     
=============================================
  Files           1976     1995      +19     
  Lines          74712    75269     +557     
  Branches        7645     7700      +55     
=============================================
+ Hits           52192    52567     +375     
- Misses         19868    20028     +160     
- Partials        2652     2674      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@habrahamsson-skanetrafiken habrahamsson-skanetrafiken merged commit 151c870 into opentripplanner:dev-2.x Oct 11, 2024
5 checks passed
t2gran pushed a commit that referenced this pull request Oct 11, 2024
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants