Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup of some OSM classes #6129

Conversation

habrahamsson-skanetrafiken
Copy link
Contributor

@habrahamsson-skanetrafiken habrahamsson-skanetrafiken commented Oct 8, 2024

Summary

Small cleanup. Pure refactoring.

  • Add @Nullable to some nullable return values.
  • generateI18NForPattern() will never be called with a null value in practice, so I removed the null check.
  • getTagsByPrefix() didn't need to return null so I removed that case.

Issue

See #6048

Unit tests

No tests for this.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.85%. Comparing base (07c72ea) to head (1385e4d).
Report is 3 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...entripplanner/openstreetmap/model/OSMWithTags.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6129   +/-   ##
==========================================
  Coverage      69.85%   69.85%           
+ Complexity     17497    17496    -1     
==========================================
  Files           1976     1976           
  Lines          74710    74705    -5     
  Branches        7645     7643    -2     
==========================================
- Hits           52191    52188    -3     
- Misses         19868    19869    +1     
+ Partials        2651     2648    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@habrahamsson-skanetrafiken habrahamsson-skanetrafiken merged commit d2b7cdd into opentripplanner:dev-2.x Oct 9, 2024
5 checks passed
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants