-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose station entrances in GraphQL API #6082
base: dev-2.x
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6082 +/- ##
=============================================
+ Coverage 69.78% 69.81% +0.02%
- Complexity 17357 17400 +43
=============================================
Files 1962 1962
Lines 74357 74450 +93
Branches 7623 7629 +6
=============================================
+ Hits 51893 51978 +85
- Misses 19820 19823 +3
- Partials 2644 2649 +5 ☔ View full report in Codecov by Sentry. |
We need to harmonise our approaches as #6076 does something similar. |
@HenrikSundell will do implement a entrance type to the graphql schema in a different pr soon-ish, and you can then use that type for the entrances in this pr instead of using the stop type. |
Thanks for the update @optionsome! Are we all aligned on returning both OSM and GTFS provided entrances in a common type? If so, it sounds like the remaining work on this PR will be to integrate with the OSM entrance data. @HenrikSundell please let me know if there is anything I can do to help or if you want to chat about synchronizing our changes. |
Yes you are correct, we will use same type for both. |
Summary
This change exposes GTFS station entrances via the GraphQL API. It provides a new top-level
entrances
query which returns all station entrances as well as a newentrances
subquery of thestations
query which returns all entrances associated with a station.Top-level query
stations
subqueryIssue
This is a proposed change as part of issue #6081. Further discussion of the implementation and API are still pending as part of this issue, but this PR hopefully will provide additional context. It is possible this PR will evolve significantly with this issue - if it makes more sense to make it a draft, I can do so.
Unit tests
Entrance
objects with their parent stationDocumentation