Make some collections in TransitModelIndex unmodifiable

opentripplanner · Oct 10, 2024 · f245442 · f245442
1 parent 2b40570
commit f245442
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/org/opentripplanner/transit/service/DefaultTransitService.java b/src/main/java/org/opentripplanner/transit/service/DefaultTransitService.java
@@ -322,7 +322,7 @@ public Collection<Route> getAllRoutes() {
         currentSnapshot.listRealTimeAddedRoutes()
       );
     }
-    return Collections.unmodifiableCollection(transitModelIndex.getAllRoutes());
+    return transitModelIndex.getAllRoutes();
   }
 
   @Override

diff --git a/src/main/java/org/opentripplanner/transit/service/TransitModelIndex.java b/src/main/java/org/opentripplanner/transit/service/TransitModelIndex.java
@@ -166,15 +166,15 @@ TripOnServiceDate getTripOnServiceDateForTripAndDay(TripIdAndServiceDate tripIdA
   }
 
   Collection<Route> getAllRoutes() {
-    return routeForId.values();
+    return Collections.unmodifiableCollection(routeForId.values());
   }
 
   TripPattern getPatternForTrip(Trip trip) {
     return patternForTrip.get(trip);
   }
 
   Collection<TripPattern> getPatternsForRoute(Route route) {
-    return patternsForRoute.get(route);
+    return Collections.unmodifiableCollection(patternsForRoute.get(route));
   }
 
   Map<LocalDate, TIntSet> getServiceCodesRunningForDate() {