This repository was archived by the owner on May 23, 2023. It is now read-only.
Allow injecting into maps of type Map<String,Object>#310
Merged
yurishkuro merged 2 commits intoopentracing:v0.32.0from Oct 19, 2018
Merged
Allow injecting into maps of type Map<String,Object>#310yurishkuro merged 2 commits intoopentracing:v0.32.0from
yurishkuro merged 2 commits intoopentracing:v0.32.0from
Conversation
For the inject case, it doesn’t matter so much that the generic type is declared as String.
carlosalberto
approved these changes
Oct 15, 2018
Member
|
not sure I follow this change. It still refers to string, and string is not extensible: |
Collaborator
|
@yurishkuro If I'm correct, it allows a |
Member
|
we should have a test demonstrating that. |
Author
|
@yurishkuro ok I modified the map in the test to use Object instead of String. Is that what you were asking for? Ideally we could do something similar for |
yurishkuro
approved these changes
Oct 16, 2018
Collaborator
|
@tylerbenson Thanks for the update @yurishkuro Ok to merge this PR? |
carlosalberto
added a commit
that referenced
this pull request
Mar 25, 2019
* Deprecate the StringTag.set() overload taking a StringTag. (#262) * Implement Trace Identifiers. (#280) * Bump JaCoCo to use a Java 10 friendly version (#306) * Remove finish span on close (#301) * Deprecate finishSpanOnClose on activation. * Add ScopeManager.activeSpan() and Tracer.activateSpan(). * Clarify the API changes and deprecations. * Add an error reporting sample to opentracing-testbed. * Simple layer on top of ByteBuffer for BINARY format. (#276) * Add generic typed setTag/withTag (#311) * Allow injecting into maps of type Map<String,Object> (#310) * Add simple registerIfAbsent to global tracer (#289) * Split Inject and Extract Builtin interfaces (#316) * Deprecate ScopeManager.active() (#326) * Make Tracer extends Closable. (#329) * Do not make isRegistered() synchronized. (#333) * Deprecate AutoFinishScopeManager (#335)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the inject case, it doesn’t matter so much that the generic type is declared as String.