Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the new "Trace Identifiers RFC" by adding
TraceId
&SpanId
members toISpanContext
.The interesting thing to discuss here is the naming collision with existing tracer properties - e.g.
MockTracer
already had properties with the same names.In this PR I changed the
MockTracer
properties tostring
but C# also has the possibility to "explicitly implement an interface" which would make it possible to keep the properties aslong
. This would look like this:Obviously, this is a bit confusing as it's quite easy to get the "wrong" type depending on what one is doing.
As
MockTracer
is used for unit tests where checking these properties is often necessary, I thought that changing the types tostring
makes this much less confusing.For a real tracer, just explicitly implementing the interface and keeping the original types for its properties might be the best option though.