Skip to content

Change opentracing version #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2018
Merged

Change opentracing version #7

merged 1 commit into from
Oct 5, 2018

Conversation

Coder-DG
Copy link
Contributor

This makes sure it's up to date with the jaeger-client opentracing requirement.
Solves #6

@carlosalberto
Copy link
Collaborator

Hey, thanks for the PR

Why opentracing>=1.1,!=1.2,<=1.3 though? Any reason it can't be pentracing>=1.1,<=1.3?

@Coder-DG
Copy link
Contributor Author

You guys wrote <1.2 so I thought something's not working with 1.2. Changed to >=1.1,<=1.3.

@carlosalberto carlosalberto merged commit d2f7ca5 into opentracing-contrib:master Oct 5, 2018
@carlosalberto
Copy link
Collaborator

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Coder-DG @carlosalberto