Create new span if parent span is missing and traceWithActiveSpanOnly = false #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raceWithActiveSpanOnly = false Signed-off-by: Sergei Malafeev <sergeymalafeev@gmail.com>
sjoerdtalsma
requested changes
Apr 4, 2019
Collaborator
sjoerdtalsma
left a comment
sjoerdtalsma
left a comment
There was a problem hiding this comment.
I see a lot of repetition of:
Scope scope = null;
if (tracer.activeSpan() == null && !traceWithActiveSpanOnly) {
scope = tracer.buildSpan(operationName).startActive(true);
}Could you extract that part into a separate method? I think it would make the code cleaner.
Signed-off-by: Sergei Malafeev <sergeymalafeev@gmail.com>
Author
|
@sjoerdtalsma done |
Author
|
@sjoerdtalsma , @pavolloffay does it looks fine? |
jpkrohling
approved these changes
Apr 5, 2019
jpkrohling
left a comment
jpkrohling
left a comment
There was a problem hiding this comment.
LGTM. Perhaps a method could have a better name, but it looks OK in general.
src/main/java/io/opentracing/contrib/concurrent/TracedScheduledExecutorService.java
Show resolved
Hide resolved
src/test/java/io/opentracing/contrib/concurrent/TracedExecutorServiceTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sergei Malafeev <sergeymalafeev@gmail.com>
Signed-off-by: Sergei Malafeev <sergeymalafeev@gmail.com>
Signed-off-by: Sergei Malafeev <sergeymalafeev@gmail.com>
Author
|
thanks guys. |
Collaborator
|
Sure I will cut a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #6
we need it for SpecialAgent
@pavolloffay please review