We should support io.StringWriter #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshegood
force-pushed
the
support.StringWriter
branch
from
99bcd99 to
1ac35d1
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces support for the io.StringWriter interface in the metrics tracker to reduce memory and CPU consumption. The changes include adding a WriteString method to metricsTracker and updating the wrappedResponseWriter function to include io.StringWriter in its returned interface combinations.
Comments suppressed due to low confidence (2)
nethttp/metrics-tracker.go:27
- Please add tests for the new WriteString method to verify that size tracking and error propagation work as expected.
func (w *metricsTracker) WriteString(s string) (int, error) {
nethttp/metrics-tracker.go:50
- Ensure that all branches in wrappedResponseWriter supporting io.StringWriter are covered by tests to validate the correct interface implementations.
io.StringWriter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce memory and CPU consumption, many libraries that implement Write also implement WriteString.
We should do the same here, as the default http server supports WriteString.