Session options prop

[julien-meichelbeck]

This will allow to use the following options :

• proxyUrl
• connectionEventsSuppressed
• ipWhitelist
• iceConfig

[msach22]

Thanks for the PR @julien-meichelbeck . I would not pass in specific options, I would just add an options object and let the SDK validate.

What do you think?

[julien-meichelbeck]

Thanks for the PR @julien-meichelbeck . I would not pass in specific options, I would just add an options object and let the SDK validate.

I wish we could but there is an eslint rules that forbids the usage of PropTypes.object so I had to specify it

[msach22]

@julien-meichelbeck Could you use PropTypes.objectOf(PropTypes.object) instead? That should be okay, I think.

[julien-meichelbeck]

Sure I can (but if you end up doing that, I think it make more sense to remove the rule, don't you think?)

[julien-meichelbeck]

It's not really an object of objects also, option types are string, bool and object

[msach22]

Yes, we can disable the rule as well. I believe this should work as well? PropTypes.shape({}). My concern is that we'll lock in specific session options in the package and then have duplication. I think it's better to rely on the SDK to validate the options.

[julien-meichelbeck]

I think it's better to rely on the SDK to validate the options.

I completely agree, that's why I disabled the rule for Proptypes.object, should be good now !

[enricop89]

LGTM

[enricop89]

Changed base branch to dev

[msach22]

LGTM