Skip to content
This repository was archived by the owner on Nov 25, 2022. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
49a2422
Default Option for Insert Default UI added which initialzes the conta…
ashifa454 Apr 14, 2020
37ca98e
Add TypeScript declaration files
janjakubnanista Apr 30, 2020
80dd3a5
Improve types for opentok, add global OT object
janjakubnanista May 7, 2020
e28e6e8
Add ref to OTSubscriberProps and OTPublisherProps
janjakubnanista May 7, 2020
cf85ed1
Change Element to HTMLElement in opentok.d.ts types
janjakubnanista May 7, 2020
ddd0fbd
Add isConnected method to Session interface
janjakubnanista May 7, 2020
f7fe151
Rename CreateSessionResult interface to SessionHelper
janjakubnanista May 7, 2020
3ecb64f
Change travis distribution to xenial
ggoldens Jul 7, 2020
4ec80cf
Merge pull request #135 from ggoldens/fix-travis
ggoldens Jul 7, 2020
16461ea
Merge branch 'dev' into feature/types
ggoldens Jul 7, 2020
0e40471
Merge pull request #117 from janjakubnanista/feature/types
ggoldens Jul 7, 2020
77c5fdf
Bump version
ggoldens Jul 7, 2020
7632ac9
Merge branch 'dev' into subscriber/insertDefaultUI
Jul 7, 2020
c1fbc0c
- fix defaulUI default value
enricop89 Jul 8, 2020
d6f93ea
Merge pull request #136 from ggoldens/bump-version
ggoldens Jul 13, 2020
dfd000f
Merge branch 'dev' into subscriber/insertDefaultUI
ggoldens Jul 13, 2020
2e3c347
Merge pull request #108 from ashifa454/subscriber/insertDefaultUI
ggoldens Jul 13, 2020
4bc08e4
Merge branch 'master' into dev
ggoldens Jul 13, 2020
0f6ce92
Add types in package.json
ggoldens Jul 15, 2020
547d90e
Merge pull request #138 from ggoldens/add-types-in-package-file
ggoldens Jul 16, 2020
c4c80be
Add newline at end of file
ggoldens Jul 16, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
example/
src/
test/
types/index.test-d.ts
types/tsconfig.json
karma.conf.js
.travis.yml
.npmignore
7 changes: 2 additions & 5 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
sudo: required
dist: trusty
services:
- xvfb
language: node_js
node_js:
- 6

before_install:
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start

script: ./node_modules/.bin/run-tests

after_failure:
Expand Down
8 changes: 6 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
{
"name": "opentok-react",
"version": "0.10.0",
"version": "0.11.0",
"description": "React components for OpenTok.js",
"main": "dist/index.js",
"scripts": {
"types": "tsd types",
"test": "karma start",
"unit": "karma start --single-run",
"prepublish": "npm run build",
Expand Down Expand Up @@ -41,6 +42,7 @@
"uuid": "^3.0.1"
},
"devDependencies": {
"@types/react": "^16.9.34",
"babel-cli": "^6.18.0",
"babel-eslint": "^7.1.1",
"babel-preset-es2015": "^6.9.0",
Expand Down Expand Up @@ -69,11 +71,13 @@
"react-dom": "^15.5.0",
"react-test-renderer": "^15.5.4",
"travis-multirunner": "^4.5.0",
"tsd": "^0.11.0",
"watchify": "^3.8.0"
},
"browserify": {
"transform": [
"babelify"
]
}
},
"types": "./types/index.d.ts"
}
11 changes: 7 additions & 4 deletions src/OTSubscriber.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,13 @@ export default class OTSubscriber extends Component {
this.setState({ subscriber: null });
return;
}

const container = document.createElement('div');
container.setAttribute('class', 'OTSubscriberContainer');
this.node.appendChild(container);
const properties = this.props.properties || {};
let container;
if (properties.insertDefaultUI !== false) {
container = document.createElement('div');
container.setAttribute('class', 'OTSubscriberContainer');
this.node.appendChild(container);
}

this.subscriberId = uuid();
const { subscriberId } = this;
Expand Down
72 changes: 72 additions & 0 deletions types/index.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
import React from 'react';
import { Session, Error, PublisherProperties, Stream, SubscriberProperties, PublisherEventHandlers, SessionEventHandlers, SubscriberEventHandlers, Subscriber, Publisher } from './opentok';

export interface OTPublisherRef {
getPublisher(): Publisher;
}

export interface OTPublisherProps {
session?: Session;
properties?: PublisherProperties;
ref?: React.Ref<OTPublisherRef>;
eventHandlers?: PublisherEventHandlers;
onInit?: () => void;
onPublish?: () => void;
onError?: (error: Error) => void;
}

export interface OTSessionProps {
apiKey: string;
sessionId: string;
token: string;
eventHandlers?: SessionEventHandlers;
onConnect?: () => void;
onError?: (error: Error) => void;
}

export interface OTStreamsProps {
children: React.ReactElement;
session?: Session;
streams?: Stream[];
}

export interface OTSubscriberRef {
getSubscriber(): Subscriber;
}

export interface OTSubscriberProps {
eventHandlers?: SubscriberEventHandlers;
properties?: SubscriberProperties;
ref?: React.Ref<OTSubscriberRef>;
session?: Session;
stream?: Stream;
onSubscribe?: () => void;
onError?: (error: Error) => void;
}

export const OTPublisher: React.ComponentType<OTPublisherProps>;
export const OTSession: React.ComponentType<OTSessionProps>;
export const OTStreams: React.ComponentType<OTStreamsProps>;
export const OTSubscriber: React.ComponentType<OTSubscriberProps>;

export interface CreateSessionOptions {
apiKey: string;
sessionId: string;
token: string;
onStreamsUpdated?: (streams: Stream[]) => void;
}

export interface SessionHelper {
session: Session;
streams: Stream[];
disconnect: () => void;
}

export function createSession(options: CreateSessionOptions): SessionHelper;

export interface PreloadScriptProps {
loadingDelegate?: React.ReactNode;
opentokClientUrl?: string;
}

export function preloadScript(component: React.ComponentType): React.ComponentType<PreloadScriptProps>;
183 changes: 183 additions & 0 deletions types/index.test-d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,183 @@
import React from 'react';
import { expectNotAssignable, expectAssignable } from 'tsd';
import { OTSessionProps, OTPublisherProps, OTStreamsProps, OTSubscriberProps, OTSubscriberRef, OTPublisherRef } from ".";
import { Error, Event, ArchiveEvent, SignalEvent, Session, AudioLevelUpdatedEvent, Stream, SubscriberProperties } from "./opentok";

/**
* OTSessionProps
*/
expectNotAssignable<OTSessionProps>({});
expectNotAssignable<OTSessionProps>({
apiKey: ''
});
expectNotAssignable<OTSessionProps>({
apiKey: '',
sessionId: ''
});

expectAssignable<OTSessionProps>({
apiKey: '',
sessionId: '',
token: ''
});
expectAssignable<OTSessionProps>({
apiKey: '',
sessionId: '',
token: '',
eventHandlers: {}
});
expectAssignable<OTSessionProps>({
apiKey: '',
sessionId: '',
token: '',
eventHandlers: {
archiveStarted: (event: ArchiveEvent) => {}
}
});
expectAssignable<OTSessionProps>({
apiKey: '',
sessionId: '',
token: '',
eventHandlers: {
archiveStarted: (event: ArchiveEvent) => {},
'signal:foo': (event: SignalEvent) => {},
'archiveStarted streamCreated': (event: Event) => {}
}
});

declare const session: Session;
declare const publisherRef: React.RefObject<OTPublisherRef>;

/**
* OTPublisherProps
*/
expectNotAssignable<OTPublisherProps>({
session: null
});
expectAssignable<OTPublisherProps>({
session,
});
expectAssignable<OTPublisherProps>({
session,
properties: {}
});
expectAssignable<OTPublisherProps>({
properties: {
audioBitrate: 10000
}
});
expectAssignable<OTPublisherProps>({
eventHandlers: {}
});
expectAssignable<OTPublisherProps>({
ref: undefined
});
expectAssignable<OTPublisherProps>({
ref: (instance: OTPublisherRef | null) => {}
});
expectAssignable<OTPublisherProps>({
ref: publisherRef
});
expectAssignable<OTPublisherProps>({
eventHandlers: {
accessAllowed: (event: Event) => undefined,
accessDenied: (event: Event<'accessDenied'>) => undefined,
destroyed: event => undefined,
audioLevelUpdated: (event: AudioLevelUpdatedEvent) => undefined
}
});
expectAssignable<OTPublisherProps>({
onInit: () => undefined
});
expectAssignable<OTPublisherProps>({
onPublish: () => undefined
});
expectAssignable<OTPublisherProps>({
onError: () => undefined
});
expectAssignable<OTPublisherProps>({
onError: (error: Error) => undefined
});

declare const node: React.ReactNode;
declare const nodeArray: React.ReactNodeArray;
declare const element: React.ReactElement;
declare const stream: Stream;

/**
* OTStreamsProps
*/
expectNotAssignable<OTStreamsProps>({});
expectNotAssignable<OTStreamsProps>({ session });
expectNotAssignable<OTStreamsProps>({ session, streams: [] });
expectNotAssignable<OTStreamsProps>({
children: node
});
expectNotAssignable<OTStreamsProps>({
children: nodeArray
});
expectAssignable<OTStreamsProps>({
children: element
});
expectAssignable<OTStreamsProps>({
children: element,
session
});
expectAssignable<OTStreamsProps>({
children: element,
streams: []
});
expectAssignable<OTStreamsProps>({
children: element,
streams: [stream]
});

declare const subscriberProperties: SubscriberProperties;
declare const subscriberRef: React.RefObject<OTSubscriberRef>;

/**
* OTSubscriberProps
*/
expectAssignable<OTSubscriberProps>({});
expectAssignable<OTSubscriberProps>({ session });
expectAssignable<OTSubscriberProps>({ stream });
expectAssignable<OTSubscriberProps>({ onSubscribe: () => undefined });
expectAssignable<OTSubscriberProps>({ onError: () => undefined });
expectAssignable<OTSubscriberProps>({ onError: error => undefined });
expectAssignable<OTSubscriberProps>({ onError: (error: Error) => undefined });
expectAssignable<OTSubscriberProps>({
properties: subscriberProperties
});
expectNotAssignable<OTSubscriberProps>({
properties: null
});
expectNotAssignable<OTSubscriberProps>({
properties: {
fitMode: NaN
}
});
expectAssignable<OTSubscriberProps>({
eventHandlers: {}
});
expectAssignable<OTSubscriberProps>({
ref: undefined
});
expectAssignable<OTSubscriberProps>({
ref: (instance: OTSubscriberRef | null) => {}
});
expectAssignable<OTSubscriberProps>({
ref: subscriberRef
});
expectAssignable<OTSubscriberProps>({
eventHandlers: {
videoDimensionsChanged: event => undefined,
audioBlocked: (event: Event) => undefined,
audioLevelUpdated: (event: AudioLevelUpdatedEvent) => undefined,
videoElementCreated: (event: Event) => undefined
}
});
expectNotAssignable<OTSubscriberProps>({
eventHandlers: {
'foo': (event: Event) => undefined
}
});
Loading