Add TypeScript declaration files

[janjakubnanista]

Fixes #91

TypeScript types were missing for opentok-react which is a pain for all TypeScript developers using the library at the moment.

I added the .d.ts files for both opentok-react and the base opentok module. This is not ideal ofc since opentok types should not live in this project. If there is a better place to put them please let me know! It also makes this pull request very large :(

I also added tsd tests for the types I created, these will check the prop types of all exported components.

[nielsdB97]

After I started working on creating types for this package myself I found this PR. I think it looks great!
The only problem I found was that your typings don't allow for a ref to be passed to OTPublisher and OTSubscriber, whereas the README indicates you can (search for ref={), for which the best solution I found was to extend the props with React.RefAttributes:

export const OTPublisher: React.ComponentType<
    OTPublisherProps & React.RefAttributes<any>
  >;

[janjakubnanista]

@nielsdB97 I added the ref properties to both OTSubscriberProps and OTPublisherProps plus added the types for the global OT object

[janjakubnanista]

@nielsdB97 I see that the CI check is hanging, is that a known issue or does something need to be done?

[nielsdB97]

@janjakubnanista for some reason the Karma tests can't be run since travis is failing to spawn a Chrome instance to run them against. According to this comment it might help to clear the Travis NPM cache, but it could also be that a new run will work, as I don't see any related code changes.

[mathieuseguin]

is there anything I could do to retry the CI build?

[ggoldens]

LGTM

[ggoldens]

@msach22 should this PR be pointing to dev branch?

[msach22]

@janjakubnanista Thanks for the PR. Could you please open it against the dev branch?

[ggoldens]

Rebasing to dev.

[msach22]

LGTM

[ggoldens]

@janjakubnanista thanks for your PR! I closed it and reopened since travis jobs were not working. Now I see it's not passing. Can you check it? Thanks!

[janjakubnanista]

@janjakubnanista thanks for your PR! I closed it and reopened since travis jobs were not working. Now I see it's not passing. Can you check it? Thanks!

@ggoldens I see that karma is failing to capture the chrome browser for unit test, this looks like an unrelated issue at first sight (I remember issues like these with karma from a ling time ago but can't quite remember what it was). Does this issue maybe appear in other PRs?

[ggoldens]

@janjakubnanista thanks for your PR! I closed it and reopened since travis jobs were not working. Now I see it's not passing. Can you check it? Thanks!

@ggoldens I see that karma is failing to capture the chrome browser for unit test, this looks like an unrelated issue at first sight (I remember issues like these with karma from a ling time ago but can't quite remember what it was). Does this issue maybe appear in other PRs?

I opened another PR to fix travis: #135

[enricop89]

@janjakubnanista thanks for the PR. One quick question: shouldn't we add the types key on the package.json?

Something like:

"types": "types/index.d.ts"

[janjakubnanista]

@enricop89 Yes indeed! Moreover there now is a new script in package.json, test, that can be used to make sure the type definitions don't break. I think it would make sense to take a look and put it somewhere in the pipeline.

[enricop89]

@janjakubnanista thanks, could you please push the changes? I'll review them