New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace arrow functions with regular functions for vanilla JS sample app #23

Merged

adrice727 merged 2 commits into opentok:master from maikthomas:issue/22

Jul 19, 2018

Contributor

maikthomas commented Jul 19, 2018 •

edited

Loading

Pull request checklist

All tests pass. Demo project builds and runs.
I have resolved any merge conflicts. Confirmation: ____

This fixes issue #22 .

This also fixes a typo: `callProperites` -> `callProperties`.

What's in this pull request?

Replaced the arrow functions with regular functions
Updated ESLINT rules
fixed callProperties typo

maikthomas added 2 commits

July 19, 2018 16:46


          Convert arrow functions to functions

1c9274c


          Fix callProperties typo

ffe1baa

maikthomas requested review from adrice727 and msach22

July 19, 2018 14:51

adrice727 approved these changes

View reviewed changes

adrice727 merged commit ff65d81 into opentok:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet