fix(base-select): fix e2e test case error

[gimmyhehe]

PR

修复E2E测试用例发现问题

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Bug Fixes
  • Improved test reliability by ensuring only visible rows are counted in dialog box row assertions.
  • Enhanced data filtering behavior for grid selection to ensure filtered results are properly loaded and displayed.

[coderabbitai]

Walkthrough

The changes update a test to count only visible grid rows within a dialog and revise the internal filtering logic in the grid-select module to use new methods for retrieving and updating table data. No changes were made to public APIs or exported entity signatures.

Changes

File(s)	Change Summary
examples/sites/demos/pc/app/popeditor/conditions.spec.ts	Modified test assertion to count only visible .tiny-grid-body__row elements within a dialog.
packages/renderless/src/grid-select/index.ts	Updated internal filter logic to use getTableData().fullData and loadTableData() for updates.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Table
    participant FilterFunction

    User->>FilterFunction: Apply filter criteria
    FilterFunction->>Table: getTableData().fullData
    Table-->>FilterFunction: Return full data
    FilterFunction->>Table: loadTableData(filteredData)
    Table-->>FilterFunction: Table data updated

Loading

Poem

In the warren of code, a test hops anew,
Now counting just rows that the user can view.
The grid’s filter logic, with data in tow,
Fetches and loads in a more modern flow.
A bunny’s delight at these neat little tweaks—
For visible rows and filtering peaks! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

examples/sites/demos/pc/app/popeditor/conditions.spec.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

packages/renderless/src/grid-select/index.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 636516b and d8090fd.

📒 Files selected for processing (2)

• examples/sites/demos/pc/app/popeditor/conditions.spec.ts (1 hunks)
• packages/renderless/src/grid-select/index.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: PR E2E Test (pnpm test:e2e3)

🔇 Additional comments (2)

packages/renderless/src/grid-select/index.ts (1)

27-31: Refactoring Verified: Consistent Use of Accessor Methods

The switch from table.afterFullData to table.getTableData().fullData and from direct assignment to table.loadTableData() is consistent across the renderless package. No remaining direct references to afterFullData were found in packages/renderless, and the new methods are used uniformly in both select and grid-select.

Great work—no further changes needed.

examples/sites/demos/pc/app/popeditor/conditions.spec.ts (1)

24-24: Ensure Playwright Test dependency is installed and verify updated assertion

The change from counting all rows to counting only visible rows aligns with the updated filtering logic in the grid-select component. To confirm everything passes:

• Install Playwright Test if it’s not present:

  npm install -D @playwright/test

• Run the updated condition test:

  npx playwright test examples/sites/demos/pc/app/popeditor/conditions.spec.ts

• Search for other .tiny-grid-body__row patterns to decide if they also need the :visible selector:

  rg "tiny-grid-body__row" -t ts -A1 -B1 examples/sites/demos/pc/app

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.