fix(grid): [grid]Fixed the problem of invalid event monitoring for configuration table selection #3328
Conversation
WalkthroughThe update enhances the event system within the grid's checkbox component by adding a secondary event emission mechanism. Specifically, after the existing events for row selection changes and select-all actions are emitted, the same events are also dispatched through the grid's internal emitter. This allows external listeners attached to the grid instance to respond to these selection events in addition to the component's own event system. No changes were made to the logic, signatures, or control flow beyond the addition of this event dispatch. Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/vue/src/grid/src/checkbox/src/methods.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis PR addresses an issue in the grid component where event monitoring for configuration table selection was not functioning correctly. The changes ensure that event listeners are now properly triggered when selections are made. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| ] | ||
| emitEvent(this, 'select-change', eventParams) | ||
| // 配置式表格事件监听 | ||
| this.$grid?.emitter.emit('select-change', eventParams) |
There was a problem hiding this comment.
Ensure that the grid's emitter is available before attempting to emit events to avoid potential runtime errors.
fix(grid): [grid]修复配置式表格选中事件监听无效问题
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit