fix(tree-menu): [tree-menu] resolve input box style issues during folding and hover status issues in dark mode

[wuyiping0628]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • The tree menu now automatically manages the visibility of the input field based on its state, reducing on-screen clutter.

• Style Enhancements

  • Adjusted icon spacing for a more balanced visual layout.
  • Introduced refined hover effects to deliver a cleaner, more interactive experience.
  • Applied smoother transitions to element visibility for a polished interface appearance.

[coderabbitai]

Walkthrough

This pull request enhances the tree menu component’s visual and interactive behavior. It introduces new CSS rules in the LESS file to adjust vertical spacing for SVG icons, apply a transparent hover background, and define an .is-hidden class that sets visibility to hidden and opacity to 0. Additionally, the Vue component now conditionally binds the is-hidden class to the <tiny-input> element based on component state, ensuring elements are properly hidden when expanded or collapsed.

Changes

Files	Change Summary
packages/theme/.../index.less	Added new CSS properties: a margin-top for .tiny-svg, a hover effect for the tree node content, and an .is-hidden class (within the input prefix block) that hides elements by setting visibility: hidden and opacity: 0.
packages/vue/.../pc.vue	Updated the <tiny-input> component to conditionally bind the is-hidden class based on state (isExpand or isCollapsed), thereby controlling the input’s visibility in the tree menu.

Sequence Diagram(s)

sequenceDiagram
    participant T as TreeMenu Component
    participant S as Component State
    participant I as Tiny Input Element

    T->>S: Check if isExpand or isCollapsed is true
    S-->>T: Return state status
    T->>I: Bind 'is-hidden' class if true
    I-->>T: Render with updated visibility

Loading

Possibly related PRs

• fix(tree): [tree]adjust the style of the tree-node to the lower part of the… #1924: Introduces a similar .is-hidden class for controlling <tiny-input> visibility.
• fix(tree): [button,tree] update tree demos and the plain button's border color #2470: Adds .is-hidden class binding in the <tiny-input> component, aligning with these updates.
• feat(tree-menu): [tree-menu] adapt to tree-menu smb themes #1866: Involves modifications to the .is-hidden class in the tree menu component, affecting element visibility.

Suggested reviewers

• zzcr

Poem

I’m a nimble rabbit in lines of code,
Hopping through CSS on my hidden road.
With a swift bound here and a joyful leap there,
I hide and show with a code-filled flair.
Carrot dreams and clean menus—oh, what a sight!
🥕🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/vue/src/tree-menu/src/pc.vue

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8597f18 and 329f207.

📒 Files selected for processing (2)

• packages/theme/src/tree-menu/index.less (3 hunks)
• packages/vue/src/tree-menu/src/pc.vue (1 hunks)

🔇 Additional comments (4)

packages/vue/src/tree-menu/src/pc.vue (1)

30-30: Good implementation of conditional class binding.

The addition of the :class="(state.isExpand || state.isCollapsed) && 'is-hidden'" binding correctly applies the is-hidden class to the input component only when the tree menu is expanded or collapsed. This approach ensures that the input is properly hidden in these states, addressing the style issues mentioned in the PR objectives.

packages/theme/src/tree-menu/index.less (3)

48-48: SVG icon vertical alignment fixed.

Adding margin-top: 2px properly aligns the SVG icon within its container, improving the visual appearance of the toggle button.

---

144-147: Appropriate implementation of the is-hidden class.

The newly added is-hidden class correctly implements both visibility: hidden and opacity: 0 to ensure the input element is completely hidden when the class is applied. This corresponds well with the class binding in the Vue component and effectively addresses the input box visibility issues during folding states.

---

243-245: Fixed hover background in dark mode.

Setting the hover background color to transparent prevents unwanted background effects when hovering over tree nodes in dark mode. This addresses the hover status issues mentioned in the PR objectives.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[petercat-assistant]

Walkthrough

This PR addresses style issues in the tree-menu component, specifically resolving input box style problems during folding and hover status issues in dark mode. It introduces new CSS classes and modifies existing styles to improve visual consistency.

Changes

Files	Summary
packages/theme/src/tree-menu/index.less	Added styles for .is-hidden class to hide elements and adjusted hover styles for better visual appearance in dark mode.
packages/vue/src/tree-menu/src/pc.vue	Updated tiny-input component to conditionally apply the is-hidden class based on state.