Skip to content

fix(modal): [modal] modifying the modal component and clicking the confirm button accidentally triggered the close event #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix(modal): [modal] modifying the modal component and clicking the confirm button accidentally triggered the close event #2727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/renderless/src/modal/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ export const handleEvent =
params.options = options
}

type !== 'close' && emit(type, params, event)
emit(type, params, event)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that removing the condition for emitting 'close' does not lead to unintended side effects, such as triggering the 'close' event in scenarios where it should not be triggered.

events[type] && events[type].call(parent, params)
api.close(type)
}
Expand Down Expand Up @@ -374,7 +374,6 @@ export const close =
setTimeout(() => {
state.visible = false
let params = { type, $modal: parent }
emit('close', params)
if (events.hide) {
events.hide.call(parent, params)
} else {
Expand Down
Loading