-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dropdown): [dropdown,action-menu,select] Additional features xdesign theme adaptation #2140
Changes from 7 commits
f01b660
1c6773a
76163e9
e74c65e
16080ea
7618f6d
3b8d606
aba0a14
2600c82
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ test('默认尺寸', async ({ page }) => { | |
const input = select.locator('.tiny-input') | ||
const tag = select.locator('.tiny-tag') | ||
|
||
await expect(input.locator('.tiny-input__inner')).toHaveCSS('height', '28px') | ||
await expect(input.locator('.tiny-input__inner')).toHaveCSS('height', '32px') | ||
await expect(tag.nth(0)).toHaveClass(/tiny-tag--light/) | ||
}) | ||
|
||
|
@@ -23,6 +23,7 @@ test('medium 尺寸', async ({ page }) => { | |
const tag = select.locator('.tiny-tag') | ||
|
||
await expect(input).toHaveClass(/tiny-input-medium/) | ||
// TODO: 此处继承input 尺寸的话,应该是32 | ||
await expect(input.locator('.tiny-input__inner')).toHaveCSS('height', '40px') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Address the TODO comment and update the height expectation if applicable. The TODO comment suggests that the expected height for the medium size input should be '32px' if inheriting from the input size. However, the current expectation is set to '40px'. Please clarify whether the height should inherit from the input size or remain at '40px', and update the test case accordingly. |
||
await expect(tag.nth(0)).toHaveClass(/tiny-tag--medium tiny-tag--light/) | ||
}) | ||
|
@@ -39,6 +40,7 @@ test('small 尺寸', async ({ page }) => { | |
|
||
await expect(input).toHaveClass(/tiny-input-small/) | ||
await expect(tag.nth(0)).toHaveClass(/tiny-tag--small tiny-tag--light/) | ||
// TODO: 此处继承input 尺寸的话,应该是28 | ||
expect(height).toBeCloseTo(32, 1) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Address the TODO comment and update the height expectation if applicable. The TODO comment suggests that the expected height for the small size input should be '28px' if inheriting from the input size. However, the current expectation is set to '32px' using the Please clarify whether the height should inherit from the input size or remain at '32px', and update the test case accordingly. |
||
}) | ||
|
||
|
@@ -54,5 +56,6 @@ test('mini 尺寸', async ({ page }) => { | |
|
||
await expect(input).toHaveClass(/tiny-input-mini/) | ||
await expect(tag.nth(0)).toHaveClass(/tiny-tag--mini tiny-tag--light/) | ||
expect(height).toBeCloseTo(24, 1) | ||
// TODO: 此处继承input 尺寸的话,应该是24 | ||
expect(height).toBeCloseTo(32, 1) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Address the TODO comment and update the height expectation if applicable. The TODO comment suggests that the expected height for the mini size input should be '24px' if inheriting from the input size. However, the current expectation is set to '32px' using the Please clarify whether the height should inherit from the input size or remain at '32px', and update the test case accordingly. |
||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Investigate and fix the root cause of the element positioning issue.
The test case is correctly locating the copy icon and checking its visibility. However, the click action on the copy icon and subsequent paste and value assertion are commented out due to an issue with element positioning during test execution.
While commenting out the affected code serves as a temporary workaround, it prevents the test case from fully verifying the copy functionality. Please investigate and fix the root cause of the element positioning issue to enable the commented-out code and ensure a reliable test suite.